mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mesos Reviewbot Windows <revi...@mesos.apache.org>
Subject Re: Review Request 66481: Converted `pid` in command executor to `Option<pid_t>`.
Date Sun, 08 Apr 2018 01:45:39 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66481/#review200713
-----------------------------------------------------------



FAIL: Some of the unit tests failed. Please check the relevant logs.

Reviews applied: `['66481']`

Failed command: `Start-MesosCITesting`

All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/66481

Relevant logs:

- [mesos-tests-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/66481/logs/mesos-tests-stdout.log):

```
[       OK ] Endpoint/SlaveEndpointTest.NoAuthorizer/2 (114 ms)
[----------] 9 tests from Endpoint/SlaveEndpointTest (1083 ms total)

[----------] 2 tests from ContainerizerType/DefaultContainerDNSFlagTest
[ RUN      ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/0
[       OK ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/0 (33 ms)
[ RUN      ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/1
[       OK ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/1 (38 ms)
[----------] 2 tests from ContainerizerType/DefaultContainerDNSFlagTest (74 ms total)

[----------] 1 test from IsolationFlag/CpuIsolatorTest
[ RUN      ] IsolationFlag/CpuIsolatorTest.ROOT_UserCpuUsage/0
[       OK ] IsolationFlag/CpuIsolatorTest.ROOT_UserCpuUsage/0 (796 ms)
[----------] 1 test from IsolationFlag/CpuIsolatorTest (823 ms total)

[----------] 1 test from IsolationFlag/MemoryIsolatorTest
[ RUN      ] IsolationFlag/MemoryIsolatorTest.ROOT_MemUsage/0
[       OK ] IsolationFlag/MemoryIsolatorTest.ROOT_MemUsage/0 (823 ms)
[----------] 1 test from IsolationFlag/MemoryIsolatorTest (850 ms total)

[----------] Global test environment tear-down
[==========] 954 tests from 94 test cases ran. (458920 ms total)
[  PASSED  ] 953 tests.
[  FAILED  ] 1 test, listed below:
[  FAILED  ] CommandExecutorCheckTest.CommandCheckTimeout

 1 FAILED TEST
  YOU HAVE 214 DISABLED TESTS

```

- [mesos-tests-stderr.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/66481/logs/mesos-tests-stderr.log):

```
I0408 01:45:25.728668  5040 exec.cpp:236] Executor registered on agent e7f23cbb-ac84-4025-939a-dc8085d64c8e-S0
I0408 01:45:25.732687 17672 executor.cpp:177] Received SUBSCRIBED event
I0408 01:45:25.737663 17672 executor.cpp:181] Subscribed executor on winbldsrv-01.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net
I0408 01:45:25.737663 17672 executor.cpp:177] Received LAUNCH event
I0408 01:45:25.742668 17672 executor.cpp:649] Starting task a77eedfe-8fb7-4c9f-a16a-93d2f051cb70
I0408 01:45:25.822664 17672 executor.cpp:484] Running 'D:\DCOS\mesos\src\mesos-containerizer.exe
launch <POSSIBLY-SENSITIVE-DATA>'
I0408 01:45:25.852685 17672 executor.cpp:662] Forked command at 5404
I0408 01:45:25.887648 10568 exec.cpp:445] Executor asked to shutdown
I0408 01:45:25.888650  7280 executor.cpp:177] Received SHUTDOWN event
I0408 01:45:25.888650  7280 executor.cpp:759] Shutting down
I0408 01:45:25.888650  7280 executor.cpp:869] Sending SIGTERM to process tree at pid 5] Deactivated
framework e7f23cbb-ac84-4025-939a-dc8085d64c8e-0000
I0408 01:45:25.884647 18536 slave.cpp:3973] Shutting down framework e7f23cbb-ac84-4025-939a-dc8085d64c8e-0000
I0408 01:45:25.884647  6160 master.cpp:10452] Updating the state of task a77eedfe-8fb7-4c9f-a16a-93d2f051cb70
of framework e7f23cbb-ac84-4025-939a-dc8085d64c8e-0000 (latest state: TASK_KILLED, status
update state: TASK_KILLED)
I0408 01:45:25.885655 18536 slave.cpp:6670] Shutting down executor 'a77eedfe-8fb7-4c9f-a16a-93d2f051cb70'
of framework e7f23cbb-ac84-4025-939a-dc8085d64c8e-0000 at executor(1)@10.3.1.8:54367
I0408 01:45:25.886646 18536 slave.cpp:923] Agent terminating
W0408 01:45:25.886646 18536 slave.cpp:3969] Ignoring shutdown framework e7f23cbb-ac84-4025-939a-dc8085d64c8e-0000
because it is terminating
I0408 01:45:25.889644  6160 master.cpp:10551] Removing task a77eedfe-8fb7-4c9f-a16a-93d2f051cb70
with resources cpus(allocated: *):4; mem(allocated: *):2048; disk(allocated: *):1024; ports(allocated:
*):[31000-32000] of framework e7f23cbb-ac84-4025-939a-dc8085d64c8e-0000 on agent e7f23cbb-ac84-4025-939a-dc8085d64c8e-S0
at slave(423)@10.3.1.8:54346 (winbldsrv-01.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net)
I0408 01:45:25.891677  8600 containerizer.cpp:2338] Destroying container 10236355-c203-47da-93c6-afa3cb3f4521
in RUNNING state
I0408 01:45:25.892654  8600 containerizer.cpp:2952] Transitioning the state of container 10236355-c203-47da-93c6-afa3cb3f4521
from RUNNING to DESTROYING
I0408 01:45:25.892654  6160 master.cpp:1295] Agent e7f23cbb-ac84-4025-939a-dc8085d64c8e-S0
at slave(423)@10.3.1.8:54346 (winbldsrv-01.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net)
disconnected
I0408 01:45:25.892654  6160 master.cpp:3286] Disconnecting agent e7f23cbb-ac84-4025-939a-dc8085d64c8e-S0
at slave(423)@10.3.1.8:54346 (winbldsrv-01.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net)
I0408 01:45:25.892654  6160 master.cpp:3305] Deactivating agent e7f23cbb-ac84-4025-939a-dc8085d64c8e-S0
at slave(423)@10.3.1.8:54346 (winbldsrv-01.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net)
I0408 01:45:25.892654 18588 hierarchical.cpp:344] Removed framework e7f23cbb-ac84-4025-939a-dc8085d64c8e-0000
I0408 01:45:25.892654  8600 launcher.cpp:156] Asked to destroy container 10236355-c203-47da-93c6-afa3cb3f4521
I0408 01:45:25.893672 18588 hierarchical.cpp:766] Agent e7f23cbb-ac84-4025-939a-dc8085d64c8e-S0
deactivated
I0408 01:45:25.935672  5876 containerizer.cpp:2791] Container 10236355-c203-47da-93c6-afa3cb3f4521
has exited
I0408 01:45:25.969674 18952 master.cpp:1137] Master terminating
I0408 01:45:25.971654 18588 hierarchical.cpp:609] Removed agent e7f23cbb-ac84-4025-939a-dc8085d64c8e-S0
I0408 01:45:26.412650 19024 process.cpp:929] Stopped the socket accept loop
```

- Mesos Reviewbot Windows


On April 7, 2018, 5:50 p.m., Zhitao Li wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66481/
> -----------------------------------------------------------
> 
> (Updated April 7, 2018, 5:50 p.m.)
> 
> 
> Review request for mesos, Andrew Schwartzmeyer and James Peach.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This avoids unix's assumption that `pid_t` is a signed integer (which is
> not the case on Windows) and explicitly shows whether a pid has been
> assigned from launching.
> 
> We also changed argument name in `reaped` method to `_pid` to avoid
> shadowing.
> 
> 
> Diffs
> -----
> 
>   src/launcher/executor.cpp 383655230fcdad30b652ea984cb9f5fc9c49dd38 
> 
> 
> Diff: https://reviews.apache.org/r/66481/diff/2/
> 
> 
> Testing
> -------
> 
> `make` on Linux.
> 
> 
> Thanks,
> 
> Zhitao Li
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message