mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Andrew Schwartzmeyer <and...@schwartzmeyer.com>
Subject Re: Review Request 66439: Windows: Made `protobuf::write()` use CRT file descriptor explicitly.
Date Fri, 06 Apr 2018 23:16:29 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66439/
-----------------------------------------------------------

(Updated April 6, 2018, 4:16 p.m.)


Review request for mesos, Akash Gupta, Eric Mumau, John Kordich, Joseph Wu, and Michael Park.


Changes
-------

Rewrote comment.


Bugs: MESOS-8675
    https://issues.apache.org/jira/browse/MESOS-8675


Repository: mesos


Description
-------

This is another edge case where a third-party library (protobuf)
requires a CRT integer file descriptor. Thus we duplicate the `int_fd`
and then explicitly allocate via `crt()`, which requires that we also
manually close it via `_close()`.


Diffs (updated)
-----

  3rdparty/stout/include/stout/protobuf.hpp 2fa5072e3c62c487da0dccffdd38d2fa1a615dc0 


Diff: https://reviews.apache.org/r/66439/diff/2/

Changes: https://reviews.apache.org/r/66439/diff/1-2/


Testing
-------


Thanks,

Andrew Schwartzmeyer


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message