mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Andrew Schwartzmeyer <and...@schwartzmeyer.com>
Subject Re: Review Request 66432: Windows: Fixed `os::write()` to use `WriteFile()`.
Date Fri, 06 Apr 2018 23:14:11 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66432/
-----------------------------------------------------------

(Updated April 6, 2018, 4:14 p.m.)


Review request for mesos, Akash Gupta, Eric Mumau, John Kordich, Joseph Wu, and Michael Park.


Changes
-------

Fixed error handling.


Bugs: MESOS-8676
    https://issues.apache.org/jira/browse/MESOS-8676


Repository: mesos


Description
-------

This can eventually support overlapped I/O.


Diffs (updated)
-----

  3rdparty/stout/include/stout/os/windows/write.hpp 71006489918d9495d37d2fdfdca08b40b419481a

  3rdparty/stout/include/stout/os/write.hpp 9ff749f209e6dd6ca3695907108a029c9a2b4f05 


Diff: https://reviews.apache.org/r/66432/diff/2/

Changes: https://reviews.apache.org/r/66432/diff/1-2/


Testing
-------


Thanks,

Andrew Schwartzmeyer


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message