-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66431/
-----------------------------------------------------------
(Updated April 6, 2018, 4:11 p.m.)
Review request for mesos, Akash Gupta, Eric Mumau, John Kordich, Joseph Wu, and Michael Park.
Changes
-------
Fixed `inline Try<std::string> read(const std::string& path)` overload for Windows
to support long paths.
Bugs: MESOS-8676
https://issues.apache.org/jira/browse/MESOS-8676
Repository: mesos
Description
-------
This can eventually support overlapped I/O.
The Windows API `ReadFile()` returns an error if the pipe is broken,
where `_read()` did not, but this is not an error for us as the data
is still read correctly. So we ignore it.
Diffs (updated)
-----
3rdparty/stout/include/stout/os/read.hpp 49878e499209fa2f91fede0ebdabb8f088a9d018
3rdparty/stout/include/stout/os/windows/read.hpp 8047ad590fcc46d3ec46b551472d8c518ae49cc1
Diff: https://reviews.apache.org/r/66431/diff/3/
Changes: https://reviews.apache.org/r/66431/diff/2-3/
Testing
-------
Thanks,
Andrew Schwartzmeyer
|