mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Andrew Schwartzmeyer <and...@schwartzmeyer.com>
Subject Re: Review Request 66428: Windows: Fixed `os::lseek()` to use `SetFilePointerEx()`.
Date Fri, 06 Apr 2018 22:53:37 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66428/
-----------------------------------------------------------

(Updated April 6, 2018, 3:53 p.m.)


Review request for mesos, Akash Gupta, Eric Mumau, John Kordich, Joseph Wu, and Michael Park.


Changes
-------

Fixed a variable name. `old_offset` was confusing.


Bugs: MESOS-8685
    https://issues.apache.org/jira/browse/MESOS-8685


Repository: mesos


Description
-------

Note the TODO, we may want to synchronize this code later.


Diffs (updated)
-----

  3rdparty/stout/include/stout/os/windows/lseek.hpp PRE-CREATION 


Diff: https://reviews.apache.org/r/66428/diff/2/

Changes: https://reviews.apache.org/r/66428/diff/1-2/


Testing
-------


Thanks,

Andrew Schwartzmeyer


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message