mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Greg Mann <g...@mesosphere.io>
Subject Re: Review Request 66461: Added an evolve function for `v1::scheduler::Response`.
Date Fri, 06 Apr 2018 21:01:03 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66461/#review200669
-----------------------------------------------------------




src/internal/evolve.hpp
Lines 120 (patched)
<https://reviews.apache.org/r/66461/#comment281508>

    Is the `mesos::` necessary in the type of the response argument here? Ditto in the implementation.


- Greg Mann


On April 4, 2018, 11:54 p.m., Gaston Kleiman wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66461/
> -----------------------------------------------------------
> 
> (Updated April 4, 2018, 11:54 p.m.)
> 
> 
> Review request for mesos and Greg Mann.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added an evolve function for `v1::scheduler::Response`.
> 
> 
> Diffs
> -----
> 
>   src/internal/evolve.hpp e00ac7175438f758b10c0aa9485fc29ffa4efa29 
>   src/internal/evolve.cpp f598ea11b64bdbface5bf1f124a02ea876196b67 
> 
> 
> Diff: https://reviews.apache.org/r/66461/diff/1/
> 
> 
> Testing
> -------
> 
> `sudo bin/mesos-tests` on GNU/Linux
> 
> 
> Thanks,
> 
> Gaston Kleiman
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message