mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mesos Reviewbot <revi...@mesos.apache.org>
Subject Re: Review Request 66481: Converted `pid` in command executor to `Option<pid_t>`.
Date Fri, 06 Apr 2018 06:27:45 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66481/#review200627
-----------------------------------------------------------



Patch looks great!

Reviews applied: [66481]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose
--disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh

- Mesos Reviewbot


On April 5, 2018, 11:31 p.m., Zhitao Li wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66481/
> -----------------------------------------------------------
> 
> (Updated April 5, 2018, 11:31 p.m.)
> 
> 
> Review request for mesos, Andrew Schwartzmeyer and James Peach.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This avoids unix's assumption that `pid_t` is a signed integer (which is
> not the case on Windows) and explicitly shows whether a pid has been
> assigned from launching.
> 
> We also changed the member variable to `pid_` to avoid variable
> shadowing in `reaped` method.
> 
> 
> Diffs
> -----
> 
>   src/launcher/executor.cpp 383655230fcdad30b652ea984cb9f5fc9c49dd38 
> 
> 
> Diff: https://reviews.apache.org/r/66481/diff/1/
> 
> 
> Testing
> -------
> 
> `make` on Linux.
> 
> 
> Thanks,
> 
> Zhitao Li
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message