mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Akash Gupta <akash-gu...@hotmail.com>
Subject Re: Review Request 66440: Replaced `open()` with `os::open()` in `http_proxy.cpp`.
Date Fri, 06 Apr 2018 02:26:55 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66440/#review200616
-----------------------------------------------------------


Fix it, then Ship it!





3rdparty/libprocess/src/http_proxy.cpp
Line 155 (original), 155 (patched)
<https://reviews.apache.org/r/66440/#comment281388>

    We might need to `#ifdef` here to handle the `GetLastError` on Windows and `errno` on
Linux.


- Akash Gupta


On April 4, 2018, 5:57 a.m., Andrew Schwartzmeyer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66440/
> -----------------------------------------------------------
> 
> (Updated April 4, 2018, 5:57 a.m.)
> 
> 
> Review request for mesos, Akash Gupta, Eric Mumau, John Kordich, Joseph Wu, and Michael
Park.
> 
> 
> Bugs: MESOS-8675
>     https://issues.apache.org/jira/browse/MESOS-8675
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Replaced `open()` with `os::open()` in `http_proxy.cpp`.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/src/http_proxy.cpp 25d63791e4788a488f96303aabeed0fa77ad7992 
> 
> 
> Diff: https://reviews.apache.org/r/66440/diff/1/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Andrew Schwartzmeyer
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message