mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Zhitao Li <zhitaoli...@gmail.com>
Subject Review Request 66481: Converted `pid` in command executor to `Option<pid_t>`.
Date Thu, 05 Apr 2018 23:31:16 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66481/
-----------------------------------------------------------

Review request for mesos, Andrew Schwartzmeyer and James Peach.


Repository: mesos


Description
-------

This avoids unix's assumption that `pid_t` is a signed integer (which is
not the case on Windows) and explicitly shows whether a pid has been
assigned from launching.

We also changed the member variable to `pid_` to avoid variable
shadowing in `reaped` method.


Diffs
-----

  src/launcher/executor.cpp 383655230fcdad30b652ea984cb9f5fc9c49dd38 


Diff: https://reviews.apache.org/r/66481/diff/1/


Testing
-------

`make` on Linux.


Thanks,

Zhitao Li


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message