mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Till Toenshoff <toensh...@me.com>
Subject Re: Review Request 65939: Updated role endpoints for hierarchical accounting.
Date Thu, 05 Apr 2018 16:15:39 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65939/
-----------------------------------------------------------

(Updated April 5, 2018, 4:15 p.m.)


Review request for mesos, Benjamin Bannier, Benjamin Mahler, Kapil Arya, Michael Park, and
Meng Zhu.


Changes
-------

Switched from snapshot view towards constant master owned hierarchical roles bookkeeping.
Added `total_frameworks` as another inherited role attribute.


Bugs: MESOS-8069
    https://issues.apache.org/jira/browse/MESOS-8069


Repository: mesos


Description (updated)
-------

When listing role "a", resources allocated to role "a/b" are added to
those allocated to role "a". These changes affect both, the "/roles"
endpoint as well as the V1 HTTP Call "GET_ROLES".
Adds dynamic hierarchical role tracking to the master.


Diffs (updated)
-----

  include/mesos/mesos.proto 676f0b090cad7ebf59eb32556f17ff8b5f247907 
  include/mesos/v1/master/master.proto ddb28f96b2a3a439bb9a829995a9a3015f65ba43 
  include/mesos/v1/mesos.proto 10d506517c9f098374ab0c8f4dcfda42e1896c95 
  src/master/http.cpp 34c9023906eca94965acc994f20e888c1f47b962 
  src/master/master.hpp 0d9620dd0c232dc1df83477e838eeb7313bf8828 
  src/master/master.cpp 18382fa93fd0c59e641e00f2028ac1ae2e67c01c 
  src/master/quota_handler.cpp 21bafd0064e9397f88185eaf687a58f85da94e2c 
  src/master/weights_handler.cpp 1053652804a8fc6af31a3b8a9f632f836c897fa9 
  src/tests/api_tests.cpp dd8e221d8fd1b2a241505345337897e4ee4a6347 
  src/tests/role_tests.cpp a609ed27ef828ca82efc0d269669cda92e5f50a1 


Diff: https://reviews.apache.org/r/65939/diff/2/

Changes: https://reviews.apache.org/r/65939/diff/1-2/


Testing
-------

make check


Thanks,

Till Toenshoff


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message