-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66439/#review200523
-----------------------------------------------------------
3rdparty/stout/include/stout/protobuf.hpp
Line 83 (original), 87 (patched)
<https://reviews.apache.org/r/66439/#comment281264>
This comment is kind of confusing. Maybe describe the scenario first, then describe what
you've implemented to resolve the scenario?
Maybe something like: "Users of 'protobuf::write' will call 'os::close' on the original
'HANDLE'. This is a problem because..."
- John Kordich
On April 4, 2018, 5:56 a.m., Andrew Schwartzmeyer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66439/
> -----------------------------------------------------------
>
> (Updated April 4, 2018, 5:56 a.m.)
>
>
> Review request for mesos, Akash Gupta, Eric Mumau, John Kordich, Joseph Wu, and Michael
Park.
>
>
> Bugs: MESOS-8675
> https://issues.apache.org/jira/browse/MESOS-8675
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This is another edge case where a third-party library (protobuf)
> requires a CRT integer file descriptor. Thus we duplicate the `int_fd`
> and then explicitly allocate via `crt()`, which requires that we also
> manually close it via `_close()`.
>
>
> Diffs
> -----
>
> 3rdparty/stout/include/stout/protobuf.hpp 2fa5072e3c62c487da0dccffdd38d2fa1a615dc0
>
>
> Diff: https://reviews.apache.org/r/66439/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Andrew Schwartzmeyer
>
>
|