mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Andrew Schwartzmeyer <and...@schwartzmeyer.com>
Subject Re: Review Request 66428: Windows: Fixed `os::lseek()` to use `SetFilePointerEx()`.
Date Wed, 04 Apr 2018 22:25:39 GMT


> On April 4, 2018, 3:21 p.m., John Kordich wrote:
> > 3rdparty/stout/include/stout/os/windows/lseek.hpp
> > Lines 36 (patched)
> > <https://reviews.apache.org/r/66428/diff/1/?file=1992272#file1992272line38>
> >
> >     That sounds like it would be user error here if this ever happens!

I agree, and we don't mutex anywhere else either.


- Andrew


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66428/#review200508
-----------------------------------------------------------


On April 3, 2018, 10:49 p.m., Andrew Schwartzmeyer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66428/
> -----------------------------------------------------------
> 
> (Updated April 3, 2018, 10:49 p.m.)
> 
> 
> Review request for mesos, Akash Gupta, Eric Mumau, John Kordich, Joseph Wu, and Michael
Park.
> 
> 
> Bugs: MESOS-8685
>     https://issues.apache.org/jira/browse/MESOS-8685
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Note the TODO, we may want to synchronize this code later.
> 
> 
> Diffs
> -----
> 
>   3rdparty/stout/include/stout/os/windows/lseek.hpp PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/66428/diff/1/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Andrew Schwartzmeyer
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message