mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Meng Zhu <m...@mesosphere.io>
Subject Re: Review Request 66412: Fixed flaky agent test.
Date Wed, 04 Apr 2018 19:23:31 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66412/
-----------------------------------------------------------

(Updated April 4, 2018, 12:23 p.m.)


Review request for mesos and Greg Mann.


Changes
-------

Added extra synchronouzation to guard against potential race conditions.


Repository: mesos


Description (updated)
-------

In test `KillTaskGroupBetweenRunTaskParts`, added extra
synchronization to ensure `unmocked__run` finishes before
the test tear down. Added `AWAIT` calls in other
tests that use dispatch calls to guard against potential
similar issues.

Also updated all dispatch calls to capture by value to avoid
potential races where the arguments might be destroyed
while the dispatch call is still running.


Diffs (updated)
-----

  src/tests/slave_tests.cpp 0d7d9726ee39e4c588ea5eb8a54a73fbe1249353 


Diff: https://reviews.apache.org/r/66412/diff/3/

Changes: https://reviews.apache.org/r/66412/diff/2-3/


Testing
-------

make check


Thanks,

Meng Zhu


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message