mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Meng Zhu <m...@mesosphere.io>
Subject Re: Review Request 65679: Removed direct unmock calls and added missing mock call expectations.
Date Wed, 04 Apr 2018 19:20:43 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65679/
-----------------------------------------------------------

(Updated April 4, 2018, 12:20 p.m.)


Review request for mesos, Chun-Hung Hsiao and Greg Mann.


Changes
-------

Updated the patch to capture by value and added extra synchronization to avoid potential race
conditions.


Bugs: MESOS-8611
    https://issues.apache.org/jira/browse/MESOS-8611


Repository: mesos


Description
-------

Directly invoking unmock calls in the test process can potentially
cause races with the real mock slave process. It is more robust to
dispatch the unmock calls to the real mock slave process.

Also added several mock expectations to avoid "uninteresting mock
call" test warnings.


Diffs (updated)
-----

  src/tests/slave_tests.cpp 0d7d9726ee39e4c588ea5eb8a54a73fbe1249353 


Diff: https://reviews.apache.org/r/65679/diff/9/

Changes: https://reviews.apache.org/r/65679/diff/8-9/


Testing
-------

`./bin/mesos-tests.sh --gtest_filter=*SlaveTest* --gtest_repeat=-1 --gtest_break_on_failure`
runs forever :)


Thanks,

Meng Zhu


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message