mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Andrew Schwartzmeyer <and...@schwartzmeyer.com>
Subject Re: Review Request 66433: Windows: Made `net::download()` use CRT file descriptor explicitly.
Date Wed, 04 Apr 2018 19:18:42 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66433/
-----------------------------------------------------------

(Updated April 4, 2018, 12:18 p.m.)


Review request for mesos, Akash Gupta, Eric Mumau, John Kordich, Joseph Wu, and Michael Park.


Changes
-------

Changed ordering.


Bugs: MESOS-8675
    https://issues.apache.org/jira/browse/MESOS-8675


Repository: mesos


Description
-------

This is an edge case where a third-party library (libcurl) requires a
CRT integer file descriptor. Thus we explicitly allocate one via
`crt()`, which requires that we also manually close it via `_close()`,
not `os::close()`.


Diffs
-----

  3rdparty/stout/include/stout/net.hpp d2992c05b221ea90dae1c06d27753932f7411925 


Diff: https://reviews.apache.org/r/66433/diff/1/


Testing
-------


Thanks,

Andrew Schwartzmeyer


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message