mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Andrew Schwartzmeyer <and...@schwartzmeyer.com>
Subject Re: Review Request 66441: Fixed mismatched types in `process.cpp`.
Date Wed, 04 Apr 2018 17:29:32 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66441/#review200468
-----------------------------------------------------------




3rdparty/libprocess/src/process.cpp
Line 1387 (original), 1387 (patched)
<https://reviews.apache.org/r/66441/#comment281209>

    Oh I know why this is needed now, because `int_fd` is convertable to `int`, which I'm
not thrilled out. I'll re-examine it...


- Andrew Schwartzmeyer


On April 3, 2018, 10:57 p.m., Andrew Schwartzmeyer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66441/
> -----------------------------------------------------------
> 
> (Updated April 3, 2018, 10:57 p.m.)
> 
> 
> Review request for mesos, Akash Gupta, Eric Mumau, John Kordich, Joseph Wu, and Michael
Park.
> 
> 
> Bugs: MESOS-8675
>     https://issues.apache.org/jira/browse/MESOS-8675
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Because of the ternary, the primitive integer `-1` must be explicitly
> constructed into an `int_fd` to match the type held in the `sockets`
> container.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/src/process.cpp 9eb37465cd86f408d69f5f98fb76c4f4b93b9acd 
> 
> 
> Diff: https://reviews.apache.org/r/66441/diff/1/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Andrew Schwartzmeyer
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message