-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66444/#review200467
-----------------------------------------------------------
I think our other option is to just delete this file, and have `os/signals.hpp` include the
POSIX version, but not the (deleted) Windows version, with a comment that none of it is (or
will be) implemented.
- Andrew Schwartzmeyer
On April 3, 2018, 10:58 p.m., Andrew Schwartzmeyer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66444/
> -----------------------------------------------------------
>
> (Updated April 3, 2018, 10:58 p.m.)
>
>
> Review request for mesos, Akash Gupta, Eric Mumau, John Kordich, Joseph Wu, and Michael
Park.
>
>
> Bugs: MESOS-8682
> https://issues.apache.org/jira/browse/MESOS-8682
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This file had never been included before, so it didn't compile. It
> needed to include `unimplemented.hpp`, and because `Suppressor` isn't
> implemented, the initializers had to be deleted.
>
>
> Diffs
> -----
>
> 3rdparty/stout/include/stout/os/windows/signals.hpp 0ed24771625e58c1de8b1aa96b70f5aae1638bd4
>
>
> Diff: https://reviews.apache.org/r/66444/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Andrew Schwartzmeyer
>
>
|