mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Andrew Schwartzmeyer <and...@schwartzmeyer.com>
Subject Review Request 66444: Windows: Made `signals.hpp` compile.
Date Wed, 04 Apr 2018 05:58:35 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66444/
-----------------------------------------------------------

Review request for mesos, Akash Gupta, Eric Mumau, John Kordich, Joseph Wu, and Michael Park.


Bugs: MESOS-8682
    https://issues.apache.org/jira/browse/MESOS-8682


Repository: mesos


Description
-------

This file had never been included before, so it didn't compile. It
needed to include `unimplemented.hpp`, and because `Suppressor` isn't
implemented, the initializers had to be deleted.


Diffs
-----

  3rdparty/stout/include/stout/os/windows/signals.hpp 0ed24771625e58c1de8b1aa96b70f5aae1638bd4



Diff: https://reviews.apache.org/r/66444/diff/1/


Testing
-------


Thanks,

Andrew Schwartzmeyer


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message