mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Andrew Schwartzmeyer <and...@schwartzmeyer.com>
Subject Review Request 66443: Fixed `Subprocess::ChildHook::CHDIR()` to use `os::chdir()`.
Date Wed, 04 Apr 2018 05:58:13 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66443/
-----------------------------------------------------------

Review request for mesos, Akash Gupta, Eric Mumau, John Kordich, Joseph Wu, and Michael Park.


Bugs: MESOS-8682
    https://issues.apache.org/jira/browse/MESOS-8682


Repository: mesos


Description
-------

This needed to use the Stout API so that the correct Windows
implementation is used, as `::chdir` is part of the CRT.

Also included used but not included `stout/os/*` headers.


Diffs
-----

  3rdparty/libprocess/src/subprocess.cpp 898326360d6b4f0a50d6ef3f7c86141d0aa70438 


Diff: https://reviews.apache.org/r/66443/diff/1/


Testing
-------


Thanks,

Andrew Schwartzmeyer


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message