mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Andrew Schwartzmeyer <and...@schwartzmeyer.com>
Subject Review Request 66438: Windows: Made `libevent` use CRT file descriptor explicitly.
Date Wed, 04 Apr 2018 05:56:36 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66438/
-----------------------------------------------------------

Review request for mesos, Akash Gupta, Eric Mumau, John Kordich, Joseph Wu, and Michael Park.


Bugs: MESOS-8675
    https://issues.apache.org/jira/browse/MESOS-8675


Repository: mesos


Description
-------

This is an edge case where a third-party library (libevent) requires a
CRT integer file descriptor. Thus we duplicate the `int_fd` and then
explicitly allocate via `crt()`, which requires that we also manually
close it via `_close()`.


Diffs
-----

  3rdparty/libprocess/src/libevent_ssl_socket.cpp 4de161dbf9198e9c74b1e80838b8a5d52006a562



Diff: https://reviews.apache.org/r/66438/diff/1/


Testing
-------


Thanks,

Andrew Schwartzmeyer


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message