mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Gilbert Song <songzihao1...@gmail.com>
Subject Re: Review Request 66039: Check both disk and inode usage when slaves schedule gc.
Date Wed, 04 Apr 2018 05:50:56 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66039/#review200429
-----------------------------------------------------------




src/slave/slave.cpp
Lines 6743 (patched)
<https://reviews.apache.org/r/66039/#comment281191>

    I would leave this to @andschwa since I suspect we could have a windows implementation
together.



src/slave/slave.cpp
Lines 6747 (patched)
<https://reviews.apache.org/r/66039/#comment281192>

    See my comment on the previous patch. We could find out the max usage at the caller side.


- Gilbert Song


On March 13, 2018, 7:05 a.m., fei long wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66039/
> -----------------------------------------------------------
> 
> (Updated March 13, 2018, 7:05 a.m.)
> 
> 
> Review request for mesos and Gilbert Song.
> 
> 
> Bugs: MESOS-8665
>     https://issues.apache.org/jira/browse/MESOS-8665
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Check both disk and inode usage when slaves schedule gc.
> 
> 
> Diffs
> -----
> 
>   src/slave/slave.cpp 2f4ab157448eafc0f41372ee50255a76129e90db 
> 
> 
> Diff: https://reviews.apache.org/r/66039/diff/2/
> 
> 
> Testing
> -------
> 
> No new tests are added and all "make check" tests are passed.
> 
> 
> Thanks,
> 
> fei long
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message