mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Gilbert Song <songzihao1...@gmail.com>
Subject Re: Review Request 66038: Add usageWithInode to check both disk and inode usage.
Date Wed, 04 Apr 2018 05:48:37 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66038/#review200427
-----------------------------------------------------------




3rdparty/stout/include/stout/posix/fs.hpp
Lines 55 (patched)
<https://reviews.apache.org/r/66038/#comment281190>

    as a library in stout, I would suggest to avoid adding `std::max`. Instead, we may want
to just implement a function called `inodeUsage()`.
    
    We could move the std::max to the caller size, which is more explicit.
    
    Thoughts?


- Gilbert Song


On March 13, 2018, 7:08 a.m., fei long wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66038/
> -----------------------------------------------------------
> 
> (Updated March 13, 2018, 7:08 a.m.)
> 
> 
> Review request for mesos and Gilbert Song.
> 
> 
> Bugs: MESOS-8665
>     https://issues.apache.org/jira/browse/MESOS-8665
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Add usageWithInode to check both disk and inode usage.
> 
> 
> Diffs
> -----
> 
>   3rdparty/stout/include/stout/posix/fs.hpp 269a4f50f1df8d68be9e11030f885cf2c254c9d8

> 
> 
> Diff: https://reviews.apache.org/r/66038/diff/2/
> 
> 
> Testing
> -------
> 
> No new tests are added and all "make check" tests are passed.
> 
> 
> Thanks,
> 
> fei long
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message