mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Andrew Schwartzmeyer <and...@schwartzmeyer.com>
Subject Review Request 66420: Windows: Extracted job object code into `os/windows/jobobject.hpp`.
Date Wed, 04 Apr 2018 05:46:59 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66420/
-----------------------------------------------------------

Review request for mesos, Akash Gupta, Eric Mumau, John Kordich, Joseph Wu, and Michael Park.


Repository: mesos


Description
-------

The functions written to deal with job objects on Windows had become
large enough to warrant being refactored into their own file. Also
was the perfect opportunity to fix formatting issues.

When including `jobobject.hpp` for `killtree.hpp`, other unnecessary
headers were removed.


Diffs
-----

  3rdparty/stout/include/Makefile.am 742bfc44d68d978dd2249ece500d6f64e4d7f02a 
  3rdparty/stout/include/stout/os/windows/jobobject.hpp PRE-CREATION 
  3rdparty/stout/include/stout/os/windows/killtree.hpp ce8bdcd18305ffb758f22a6c2bbc7393675aebdf

  3rdparty/stout/include/stout/windows/os.hpp 739ee4da3f09d2a9597d4451e755e77903e9287d 


Diff: https://reviews.apache.org/r/66420/diff/1/


Testing
-------


Thanks,

Andrew Schwartzmeyer


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message