mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From David Forsythe <dforsy...@gmail.com>
Subject Re: Review Request 66392: Find sasl2 on non-Windows platforms before trying to link it.
Date Wed, 04 Apr 2018 03:46:43 GMT


> On April 3, 2018, 4:36 p.m., Andrew Schwartzmeyer wrote:
> > 3rdparty/CMakeLists.txt
> > Lines 267 (patched)
> > <https://reviews.apache.org/r/66392/diff/2/?file=1991658#file1991658line267>
> >
> >     This looks good; except I think in generaly it's going to find a shared version
of `sasl2` not a static. I don't think it really does too much to imported targets, as they're
not being built, but for accuracy's sake, `add_library(sasl2 SHARED IMPORTED GLOBAL)` (unless
we really don't know, so `UNKNOWN`).

Yup. Fixed.


- David


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66392/#review200370
-----------------------------------------------------------


On April 4, 2018, 3:46 a.m., David Forsythe wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66392/
> -----------------------------------------------------------
> 
> (Updated April 4, 2018, 3:46 a.m.)
> 
> 
> Review request for mesos and Andrew Schwartzmeyer.
> 
> 
> Bugs: MESOS-4176
>     https://issues.apache.org/jira/browse/MESOS-4176
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Find sasl2 on non-Windows platforms before trying to link it.
> 
> 
> Diffs
> -----
> 
>   3rdparty/CMakeLists.txt 2b63b58f7d6a88c9986b746283dcfa79b7bcb270 
> 
> 
> Diff: https://reviews.apache.org/r/66392/diff/3/
> 
> 
> Testing
> -------
> 
> make on FreeBSD
> 
> 
> Thanks,
> 
> David Forsythe
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message