mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Greg Mann <g...@mesosphere.io>
Subject Re: Review Request 66347: Added a test for killing executor during task launch.
Date Wed, 04 Apr 2018 00:58:34 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66347/#review200404
-----------------------------------------------------------




src/tests/slave_tests.cpp
Lines 5563 (patched)
<https://reviews.apache.org/r/66347/#comment281167>

    Move this down above its first use.



src/tests/slave_tests.cpp
Lines 5584 (patched)
<https://reviews.apache.org/r/66347/#comment281168>

    I think we usually split these onto separate lines in the tests (i.e., `.WillOnce` on
a new line). Could you do that here and below?



src/tests/slave_tests.cpp
Lines 5592 (patched)
<https://reviews.apache.org/r/66347/#comment281170>

    Is this needed?



src/tests/slave_tests.cpp
Lines 5641 (patched)
<https://reviews.apache.org/r/66347/#comment281171>

    s/taskgroup2/task group 2/
    
    or
    
    s/taskgroup2/`taskGroup2`/
    
    here and below.



src/tests/slave_tests.cpp
Lines 5650 (patched)
<https://reviews.apache.org/r/66347/#comment281173>

    s/promiseTask2/promise/



src/tests/slave_tests.cpp
Lines 5651 (patched)
<https://reviews.apache.org/r/66347/#comment281174>

    Is the underscore necessary in this variable name?



src/tests/slave_tests.cpp
Lines 5673 (patched)
<https://reviews.apache.org/r/66347/#comment281172>

    s/Taskgroup1/Task group 1/
    
    or
    
    s/Taskgroup1/`taskGroup1`/
    
    here and below.



src/tests/slave_tests.cpp
Lines 5702 (patched)
<https://reviews.apache.org/r/66347/#comment281175>

    As discussed in chat, let's capture by value here.


- Greg Mann


On March 28, 2018, 10:46 p.m., Meng Zhu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66347/
> -----------------------------------------------------------
> 
> (Updated March 28, 2018, 10:46 p.m.)
> 
> 
> Review request for mesos and Greg Mann.
> 
> 
> Bugs: MESOS-8617 and MESOS-8624
>     https://issues.apache.org/jira/browse/MESOS-8617
>     https://issues.apache.org/jira/browse/MESOS-8624
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This test verifies that when agent shuts down a running
> executor, launching tasks on the agent that use the same
> executor will be dropped properly.
> 
> 
> Diffs
> -----
> 
>   src/tests/slave_tests.cpp 0d7d9726ee39e4c588ea5eb8a54a73fbe1249353 
> 
> 
> Diff: https://reviews.apache.org/r/66347/diff/1/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Meng Zhu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message