mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Greg Mann <g...@mesosphere.io>
Subject Re: Review Request 66323: Added tests for failed task launch on agent.
Date Wed, 04 Apr 2018 00:17:21 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66323/#review200398
-----------------------------------------------------------




src/tests/slave_tests.cpp
Lines 5208 (patched)
<https://reviews.apache.org/r/66323/#comment281126>

    This test does actually launch task groups, so maybe:
    
    s/task(group)s/task groups/
    
    here and below.



src/tests/slave_tests.cpp
Lines 5210 (patched)
<https://reviews.apache.org/r/66323/#comment281127>

    s/first task (in the agent receiving order)/first received task/
    
    here and below.



src/tests/slave_tests.cpp
Lines 5212 (patched)
<https://reviews.apache.org/r/66323/#comment281129>

    s/TasksLaunch/LaunchTasks/



src/tests/slave_tests.cpp
Lines 5220 (patched)
<https://reviews.apache.org/r/66323/#comment281130>

    Could you move this down above the site of its first use?



src/tests/slave_tests.cpp
Lines 5249 (patched)
<https://reviews.apache.org/r/66323/#comment281138>

    Is this necessary?



src/tests/slave_tests.cpp
Lines 5251-5252 (patched)
<https://reviews.apache.org/r/66323/#comment281139>

    Is this needed?



src/tests/slave_tests.cpp
Lines 5272 (patched)
<https://reviews.apache.org/r/66323/#comment281142>

    Looks like this could be just `executorInfo`? Here and below.



src/tests/slave_tests.cpp
Lines 5275 (patched)
<https://reviews.apache.org/r/66323/#comment281144>

    s/two/three/
    
    Also, I would add a newline after this comment, since it applies to multiple blocks of
code below.



src/tests/slave_tests.cpp
Lines 5317 (patched)
<https://reviews.apache.org/r/66323/#comment281145>

    s/both/all/



src/tests/slave_tests.cpp
Lines 5320-5344 (patched)
<https://reviews.apache.org/r/66323/#comment281161>

    As discussed in chat, here we're making the assumption that the first invocation of `_run()`
corresponds to `taskGroup1`, which is not necessarily true. Let's make use of your matchers
to address this, here and below.



src/tests/slave_tests.cpp
Lines 5348-5349 (patched)
<https://reviews.apache.org/r/66323/#comment281153>

    Indent two more spaces.



src/tests/slave_tests.cpp
Lines 5351 (patched)
<https://reviews.apache.org/r/66323/#comment281149>

    Let's split this into 3 separate AWAIT_READY calls.



src/tests/slave_tests.cpp
Lines 5364 (patched)
<https://reviews.apache.org/r/66323/#comment281154>

    I would either do
    
    s/taskgroup1/`taskGroup1`/
    
    or
    
    s/taskgroup1/task group 1/
    
    here and below.



src/tests/slave_tests.cpp
Lines 5365 (patched)
<https://reviews.apache.org/r/66323/#comment281155>

    As discussed in chat, let's capture by value here and elsewhere.



src/tests/slave_tests.cpp
Lines 5447 (patched)
<https://reviews.apache.org/r/66323/#comment281156>

    Let's put the `.WillOnce` on a new line for consistency.



src/tests/slave_tests.cpp
Lines 5456-5457 (patched)
<https://reviews.apache.org/r/66323/#comment281157>

    Is this needed?



src/tests/slave_tests.cpp
Lines 5506 (patched)
<https://reviews.apache.org/r/66323/#comment281158>

    Indented too far.



src/tests/slave_tests.cpp
Lines 5537 (patched)
<https://reviews.apache.org/r/66323/#comment281159>

    Indent two more spaces.



src/tests/slave_tests.cpp
Lines 5539 (patched)
<https://reviews.apache.org/r/66323/#comment281160>

    Let's split this into 2 AWAIT_READY calls.


- Greg Mann


On March 30, 2018, 6:10 p.m., Meng Zhu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66323/
> -----------------------------------------------------------
> 
> (Updated March 30, 2018, 6:10 p.m.)
> 
> 
> Review request for mesos and Greg Mann.
> 
> 
> Bugs: MESOS-8617 and MESOS-8624
>     https://issues.apache.org/jira/browse/MESOS-8617
>     https://issues.apache.org/jira/browse/MESOS-8624
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This test verifies the agent behavior of launching
> two task(group)s using the same executor. When both
> tasks are launching on the agent (before creating
> any executor), if the first task (in the agent receiving
> order) fails to launch, the later task will get dropped.
> If the later task fails to launch, the first task
> should still launch successfully.
> 
> 
> Diffs
> -----
> 
>   src/tests/slave_tests.cpp 0d7d9726ee39e4c588ea5eb8a54a73fbe1249353 
> 
> 
> Diff: https://reviews.apache.org/r/66323/diff/3/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Meng Zhu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message