mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Meng Zhu <m...@mesosphere.io>
Subject Review Request 66412: Fixed flaky agent test.
Date Tue, 03 Apr 2018 22:10:22 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66412/
-----------------------------------------------------------

Review request for mesos and Greg Mann.


Repository: mesos


Description
-------

In test `KillTaskGroupBetweenRunTaskParts`, added extra
synchronization to ensure `unmocked__run` finishes before
the test tear down.

Also updated all dispatch calls to capture by value to avoid
potential races where the arguments might be destroyed
while the dispatch call is still running.


Diffs
-----

  src/tests/slave_tests.cpp 0d7d9726ee39e4c588ea5eb8a54a73fbe1249353 


Diff: https://reviews.apache.org/r/66412/diff/1/


Testing
-------

make check


Thanks,

Meng Zhu


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message