mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Meng Zhu <m...@mesosphere.io>
Subject Re: Review Request 66178: Added a test to verify that task launch order is enforced.
Date Tue, 03 Apr 2018 19:07:57 GMT


> On April 3, 2018, 10:51 a.m., Greg Mann wrote:
> > src/tests/slave_tests.cpp
> > Lines 5114 (patched)
> > <https://reviews.apache.org/r/66178/diff/2/?file=1984774#file1984774line5114>
> >
> >     Is this necessary?

To avoid uninteresing mock call.


> On April 3, 2018, 10:51 a.m., Greg Mann wrote:
> > src/tests/slave_tests.cpp
> > Lines 5181-5182 (patched)
> > <https://reviews.apache.org/r/66178/diff/2/?file=1984774#file1984774line5181>
> >
> >     Should we assert here that task 2 has not launched yet?

Good point.


- Meng


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66178/#review200381
-----------------------------------------------------------


On March 21, 2018, 2:58 p.m., Meng Zhu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66178/
> -----------------------------------------------------------
> 
> (Updated March 21, 2018, 2:58 p.m.)
> 
> 
> Review request for mesos, Chun-Hung Hsiao and Greg Mann.
> 
> 
> Bugs: MESOS-8617 and MESOS-8624
>     https://issues.apache.org/jira/browse/MESOS-8617
>     https://issues.apache.org/jira/browse/MESOS-8624
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Agent should launch the task in their receiving order.
> On the task launch path, there are currently two
> asynchronous steps which may complete out of order:
> unschedule GC and task authorization.
> 
> This test simulates the reordering of the completions
> of task authorization step and verify that, despite the
> reordering, tasks can still launch in their original order.
> 
> 
> Diffs
> -----
> 
>   src/tests/mesos.hpp 46c271b5c5bedbdabd58b3cdbb82216d55c846bd 
>   src/tests/mesos.cpp d82963195573dd9ed7d12a7708f64a236b28cdf1 
>   src/tests/slave_tests.cpp 0d7d9726ee39e4c588ea5eb8a54a73fbe1249353 
> 
> 
> Diff: https://reviews.apache.org/r/66178/diff/3/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Meng Zhu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message