mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Greg Mann <g...@mesosphere.io>
Subject Re: Review Request 66178: Added a test to verify that task launch order is enforced.
Date Tue, 03 Apr 2018 17:51:53 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66178/#review200381
-----------------------------------------------------------




src/tests/slave_tests.cpp
Lines 5070 (patched)
<https://reviews.apache.org/r/66178/#comment281097>

    s/runTask(Group)Message/RunTask(Group)Message/



src/tests/slave_tests.cpp
Lines 5073 (patched)
<https://reviews.apache.org/r/66178/#comment281100>

    I would recommend the name `LaunchTasksReorderTaskAuthorization`.



src/tests/slave_tests.cpp
Lines 5081 (patched)
<https://reviews.apache.org/r/66178/#comment281102>

    Ditto here - move this down a bit.



src/tests/slave_tests.cpp
Lines 5083-5088 (patched)
<https://reviews.apache.org/r/66178/#comment281101>

    Ditto on consistent newlines here.



src/tests/slave_tests.cpp
Lines 5114 (patched)
<https://reviews.apache.org/r/66178/#comment281103>

    Is this necessary?



src/tests/slave_tests.cpp
Lines 5176-5177 (patched)
<https://reviews.apache.org/r/66178/#comment281104>

    Need a period at the end of this comment.



src/tests/slave_tests.cpp
Lines 5180 (patched)
<https://reviews.apache.org/r/66178/#comment281105>

    Nit: enclose `taskGroup2` in backticks, here and elsewhere.



src/tests/slave_tests.cpp
Lines 5181-5182 (patched)
<https://reviews.apache.org/r/66178/#comment281106>

    Should we assert here that task 2 has not launched yet?



src/tests/slave_tests.cpp
Lines 5186 (patched)
<https://reviews.apache.org/r/66178/#comment281107>

    s/subseuqently/subsequently/


- Greg Mann


On March 21, 2018, 9:58 p.m., Meng Zhu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66178/
> -----------------------------------------------------------
> 
> (Updated March 21, 2018, 9:58 p.m.)
> 
> 
> Review request for mesos, Chun-Hung Hsiao and Greg Mann.
> 
> 
> Bugs: MESOS-8617 and MESOS-8624
>     https://issues.apache.org/jira/browse/MESOS-8617
>     https://issues.apache.org/jira/browse/MESOS-8624
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Agent should launch the task in their receiving order.
> On the task launch path, there are currently two
> asynchronous steps which may complete out of order:
> unschedule GC and task authorization.
> 
> This test simulates the reordering of the completions
> of task authorization step and verify that, despite the
> reordering, tasks can still launch in their original order.
> 
> 
> Diffs
> -----
> 
>   src/tests/mesos.hpp 2c3d0c9350bbbbcd2223ff20c0797d1849d38c19 
>   src/tests/mesos.cpp d82963195573dd9ed7d12a7708f64a236b28cdf1 
>   src/tests/slave_tests.cpp f76500ebdb67f131a57a3b5aaae8c952d019e354 
> 
> 
> Diff: https://reviews.apache.org/r/66178/diff/2/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Meng Zhu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message