mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Meng Zhu <m...@mesosphere.io>
Subject Re: Review Request 66126: Refactored agent task launch for better composition [1/2].
Date Tue, 03 Apr 2018 17:37:37 GMT


> On April 2, 2018, 3:38 p.m., Greg Mann wrote:
> > src/slave/slave.cpp
> > Line 2166 (original), 2221-2227 (patched)
> > <https://reviews.apache.org/r/66126/diff/4/?file=1991113#file1991113line2222>
> >
> >     Ah whoops, we should defer this continuation to `self()`. I think it's probably
safe at the moment, but best to always defer/dispatch except for trivial continuations which
do not access actor state. Even if the current implementation is safe, it makes the code less
fragile if we defer.
> 
> Meng Zhu wrote:
>     See my reply in https://reviews.apache.org/r/66144/

OK, need to defer, as the error handler might be called in a different context other than
the agent actor.


- Meng


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66126/#review200324
-----------------------------------------------------------


On April 2, 2018, 5:33 p.m., Meng Zhu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66126/
> -----------------------------------------------------------
> 
> (Updated April 2, 2018, 5:33 p.m.)
> 
> 
> Review request for mesos, Chun-Hung Hsiao and Greg Mann.
> 
> 
> Bugs: MESOS-8617 and MESOS-8624
>     https://issues.apache.org/jira/browse/MESOS-8617
>     https://issues.apache.org/jira/browse/MESOS-8624
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This helps to encapsulate a task launch into a single
> future which will come in handy when enforcing the task
> launch order.
> 
> This patch also consolidated the error handling code
> in the task launch path.
> 
> Affected tests are also updated.
> 
> 
> Diffs
> -----
> 
>   src/slave/slave.hpp 37f0361251524e63d02d251e8a03901812b8affb 
>   src/slave/slave.cpp a4bd4ccd3fc59c3c0e462d9b480f5424b3e52d7a 
>   src/tests/mock_slave.hpp 8ec2b65a75f774d970ef6507df8b0c02fda5f2fd 
>   src/tests/mock_slave.cpp 8ec55b6aa84dd8b1c3743cbcdc246311585d0f63 
>   src/tests/slave_tests.cpp 0d7d9726ee39e4c588ea5eb8a54a73fbe1249353 
> 
> 
> Diff: https://reviews.apache.org/r/66126/diff/6/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Meng Zhu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message