mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From David Forsythe <dforsy...@gmail.com>
Subject Re: Review Request 66392: Find sasl2 on non-Windows platforms before trying to link it.
Date Tue, 03 Apr 2018 14:12:13 GMT


> On April 2, 2018, 6:44 p.m., Andrew Schwartzmeyer wrote:
> > 3rdparty/CMakeLists.txt
> > Line 1051 (original), 1051 (patched)
> > <https://reviews.apache.org/r/66392/diff/1/?file=1991209#file1991209line1051>
> >
> >     Don't think you mean to have this here.

Ah sorry, will remove.


> On April 2, 2018, 6:44 p.m., Andrew Schwartzmeyer wrote:
> > src/CMakeLists.txt
> > Lines 513-514 (original), 512-516 (patched)
> > <https://reviews.apache.org/r/66392/diff/1/?file=1991210#file1991210line513>
> >
> >     Instead of this, we should have a `NOT WIN32` section in 3rdparty/CMakeLists.txt
that does `find_library(sasl2)` and then creates an imported `sasl2` target, that way `sasl2`
will be a target on both Windows and non-Windows platforms, and this code can go unchanged.

Fixed. Let me know if there is a better way to do it.


- David


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66392/#review200307
-----------------------------------------------------------


On April 3, 2018, 2:11 p.m., David Forsythe wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66392/
> -----------------------------------------------------------
> 
> (Updated April 3, 2018, 2:11 p.m.)
> 
> 
> Review request for mesos and Andrew Schwartzmeyer.
> 
> 
> Bugs: MESOS-4176
>     https://issues.apache.org/jira/browse/MESOS-4176
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Find sasl2 on non-Windows platforms before trying to link it.
> 
> 
> Diffs
> -----
> 
>   3rdparty/CMakeLists.txt 2b63b58f7d6a88c9986b746283dcfa79b7bcb270 
> 
> 
> Diff: https://reviews.apache.org/r/66392/diff/2/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> David Forsythe
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message