mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From David Forsythe <dforsy...@gmail.com>
Subject Re: Review Request 66385: Link execinfo in Glog build on FreeBSD.
Date Tue, 03 Apr 2018 04:58:35 GMT


> On April 2, 2018, 5:05 p.m., Andrew Schwartzmeyer wrote:
> > 3rdparty/CMakeLists.txt
> > Lines 359-361 (patched)
> > <https://reviews.apache.org/r/66385/diff/1/?file=1990751#file1990751line359>
> >
> >     This looks confusing (else then if endif), but I think it's because the indentation
is off. This is supposed to be under the above `else ()`, right?

Indeed, will fix.


> On April 2, 2018, 5:05 p.m., Andrew Schwartzmeyer wrote:
> > 3rdparty/CMakeLists.txt
> > Lines 360 (patched)
> > <https://reviews.apache.org/r/66385/diff/1/?file=1990751#file1990751line360>
> >
> >     Is this something that should actually go upstream to Glog? If so, let's make
sure it does.

I'll add it to my todo list.


> On April 2, 2018, 5:05 p.m., Andrew Schwartzmeyer wrote:
> > cmake/CompilationConfigure.cmake
> > Lines 304-306 (patched)
> > <https://reviews.apache.org/r/66385/diff/1/?file=1990752#file1990752line304>
> >
> >     FWIW we want to remove these eventually, as they create a dependency on the
top-level project (Mesos) within the "3rdparty" projects (like stout).
> >     
> >     Since we already have `LINUX` to fix, it's probably fine, as we're not really
breaking it any further.

I'll try to avoid using it anywhere else.


- David


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66385/#review200291
-----------------------------------------------------------


On April 3, 2018, 4:58 a.m., David Forsythe wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66385/
> -----------------------------------------------------------
> 
> (Updated April 3, 2018, 4:58 a.m.)
> 
> 
> Review request for mesos and Andrew Schwartzmeyer.
> 
> 
> Bugs: MESOS-4176 and MESOS-6849
>     https://issues.apache.org/jira/browse/MESOS-4176
>     https://issues.apache.org/jira/browse/MESOS-6849
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Link execinfo in Glog build on FreeBSD.
> 
> 
> Diffs
> -----
> 
>   3rdparty/CMakeLists.txt 2b63b58f7d6a88c9986b746283dcfa79b7bcb270 
>   cmake/CompilationConfigure.cmake 64cc56ee4208afe05df0f28af5890157e4c7d82c 
> 
> 
> Diff: https://reviews.apache.org/r/66385/diff/2/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> David Forsythe
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message