mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From David Forsythe <dforsy...@gmail.com>
Subject Re: Review Request 66384: Link libm in ZooKeeper build on FreeBSD.
Date Tue, 03 Apr 2018 04:31:36 GMT


> On April 2, 2018, 5:02 p.m., Andrew Schwartzmeyer wrote:
> > 3rdparty/zookeeper-3.4.8.patch
> > Lines 870-873 (original), 870-872 (patched)
> > <https://reviews.apache.org/r/66384/diff/1/?file=1990750#file1990750line870>
> >
> >     This is funny, what did this get diffed against? I might have screwed up in
my original diff...

I used the archive in the repo. I don't know what the workflow for changes like this is supposed
to look like, but this is as close as I could get.


- David


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66384/#review200289
-----------------------------------------------------------


On April 1, 2018, 2:32 a.m., David Forsythe wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66384/
> -----------------------------------------------------------
> 
> (Updated April 1, 2018, 2:32 a.m.)
> 
> 
> Review request for mesos and Andrew Schwartzmeyer.
> 
> 
> Bugs: MESOS-4176
>     https://issues.apache.org/jira/browse/MESOS-4176
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Link libm in ZooKeeper build on FreeBSD.
> 
> 
> Diffs
> -----
> 
>   3rdparty/zookeeper-3.4.8.patch 2eaa056dd5668d5842b5b59a42f83ae307d4aef0 
> 
> 
> Diff: https://reviews.apache.org/r/66384/diff/1/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> David Forsythe
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message