mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Greg Mann <g...@mesosphere.io>
Subject Re: Review Request 66126: Refactored agent task launch for better composition [1/2].
Date Mon, 02 Apr 2018 22:25:28 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66126/#review200322
-----------------------------------------------------------


Fix it, then Ship it!





src/slave/slave.cpp
Lines 2158 (patched)
<https://reviews.apache.org/r/66126/#comment281019>

    I prefer trailing underscores for cases like this (as does our style guide), but since
we have another case above in this function where we use a leading underscore for `_task`,
let's try to be locally consistent here and use `_framework` instead.



src/slave/slave.cpp
Lines 2159-2162 (patched)
<https://reviews.apache.org/r/66126/#comment281018>

    How about
    
    "Cannot handle unschedule GC failure for <task> because the framework <frameworkID>
does not exist"



src/slave/slave.cpp
Lines 2169-2170 (patched)
<https://reviews.apache.org/r/66126/#comment281017>

    Let's move this log to the top of the lambda, since the failure has occurred even if we
cannot locate the framework.


- Greg Mann


On April 2, 2018, 5:57 p.m., Meng Zhu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66126/
> -----------------------------------------------------------
> 
> (Updated April 2, 2018, 5:57 p.m.)
> 
> 
> Review request for mesos, Chun-Hung Hsiao and Greg Mann.
> 
> 
> Bugs: MESOS-8617 and MESOS-8624
>     https://issues.apache.org/jira/browse/MESOS-8617
>     https://issues.apache.org/jira/browse/MESOS-8624
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This helps to encapsulate a task launch into a single
> future which will come in handy when enforcing the task
> launch order.
> 
> This patch also consolidated the error handling code
> in the task launch path.
> 
> Affected tests are also updated.
> 
> 
> Diffs
> -----
> 
>   src/slave/slave.hpp 37f0361251524e63d02d251e8a03901812b8affb 
>   src/slave/slave.cpp a4bd4ccd3fc59c3c0e462d9b480f5424b3e52d7a 
>   src/tests/mock_slave.hpp 8ec2b65a75f774d970ef6507df8b0c02fda5f2fd 
>   src/tests/mock_slave.cpp 8ec55b6aa84dd8b1c3743cbcdc246311585d0f63 
>   src/tests/slave_tests.cpp 0d7d9726ee39e4c588ea5eb8a54a73fbe1249353 
> 
> 
> Diff: https://reviews.apache.org/r/66126/diff/4/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Meng Zhu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message