mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Gaston Kleiman <gas...@mesosphere.io>
Subject Re: Review Request 66365: Fixed generation of operation statuses in `Slave::applyOperation()`.
Date Mon, 02 Apr 2018 17:15:21 GMT


> On March 30, 2018, 8:38 a.m., Greg Mann wrote:
> > src/slave/slave.cpp
> > Lines 4266-4268 (patched)
> > <https://reviews.apache.org/r/66365/diff/1/?file=1990343#file1990343line4266>
> >
> >     Was this formatting produced by clang-format?
> >     
> >     I would probably do:
> >     ```
> >       Option<OperationID> operationId =
> >         message.operation_info().has_id()
> >           ? message.operation_info().id()
> >           : Option<OperationID>::none();
> >     ```
> >     but if clang-format generated this, then let's just keep it.

Yeah, our `clang-format` generated it... but as discussed offline, I updated the patch to
match the style of the ternary statement right above this one.


- Gaston


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66365/#review200239
-----------------------------------------------------------


On April 2, 2018, 10:15 a.m., Gaston Kleiman wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66365/
> -----------------------------------------------------------
> 
> (Updated April 2, 2018, 10:15 a.m.)
> 
> 
> Review request for mesos and Greg Mann.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This patch updates `Slave::applyOperation()` to make it include the
> operation ID in operation statuses for operations that have an ID.
> 
> 
> Diffs
> -----
> 
>   src/slave/slave.cpp a4bd4ccd3fc59c3c0e462d9b480f5424b3e52d7a 
> 
> 
> Diff: https://reviews.apache.org/r/66365/diff/2/
> 
> 
> Testing
> -------
> 
> Tests still pass on GNU/Linux.
> 
> 
> Thanks,
> 
> Gaston Kleiman
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message