mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Andrew Schwartzmeyer <and...@schwartzmeyer.com>
Subject Re: Review Request 66385: Link execinfo in Glog build on FreeBSD.
Date Mon, 02 Apr 2018 17:05:39 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66385/#review200291
-----------------------------------------------------------




3rdparty/CMakeLists.txt
Lines 359-361 (patched)
<https://reviews.apache.org/r/66385/#comment280980>

    This looks confusing (else then if endif), but I think it's because the indentation is
off. This is supposed to be under the above `else ()`, right?



3rdparty/CMakeLists.txt
Lines 360 (patched)
<https://reviews.apache.org/r/66385/#comment280982>

    Is this something that should actually go upstream to Glog? If so, let's make sure it
does.



cmake/CompilationConfigure.cmake
Lines 304-306 (patched)
<https://reviews.apache.org/r/66385/#comment280981>

    FWIW we want to remove these eventually, as they create a dependency on the top-level
project (Mesos) within the "3rdparty" projects (like stout).
    
    Since we already have `LINUX` to fix, it's probably fine, as we're not really breaking
it any further.


- Andrew Schwartzmeyer


On March 31, 2018, 7:33 p.m., David Forsythe wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66385/
> -----------------------------------------------------------
> 
> (Updated March 31, 2018, 7:33 p.m.)
> 
> 
> Review request for mesos and Andrew Schwartzmeyer.
> 
> 
> Bugs: MESOS-4176 and MESOS-6849
>     https://issues.apache.org/jira/browse/MESOS-4176
>     https://issues.apache.org/jira/browse/MESOS-6849
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Link execinfo in Glog build on FreeBSD.
> 
> 
> Diffs
> -----
> 
>   3rdparty/CMakeLists.txt 2b63b58f7d6a88c9986b746283dcfa79b7bcb270 
>   cmake/CompilationConfigure.cmake 64cc56ee4208afe05df0f28af5890157e4c7d82c 
> 
> 
> Diff: https://reviews.apache.org/r/66385/diff/1/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> David Forsythe
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message