mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Andrew Schwartzmeyer <and...@schwartzmeyer.com>
Subject Re: Review Request 66384: Link libm in ZooKeeper build on FreeBSD.
Date Mon, 02 Apr 2018 17:02:10 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66384/#review200289
-----------------------------------------------------------




3rdparty/zookeeper-3.4.8.patch
Line 154 (original), 154 (patched)
<https://reviews.apache.org/r/66384/#comment280978>

    LGTM



3rdparty/zookeeper-3.4.8.patch
Lines 870-873 (original), 870-872 (patched)
<https://reviews.apache.org/r/66384/#comment280975>

    This is funny, what did this get diffed against? I might have screwed up in my original
diff...


- Andrew Schwartzmeyer


On March 31, 2018, 7:32 p.m., David Forsythe wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66384/
> -----------------------------------------------------------
> 
> (Updated March 31, 2018, 7:32 p.m.)
> 
> 
> Review request for mesos and Andrew Schwartzmeyer.
> 
> 
> Bugs: MESOS-4176
>     https://issues.apache.org/jira/browse/MESOS-4176
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Link libm in ZooKeeper build on FreeBSD.
> 
> 
> Diffs
> -----
> 
>   3rdparty/zookeeper-3.4.8.patch 2eaa056dd5668d5842b5b59a42f83ae307d4aef0 
> 
> 
> Diff: https://reviews.apache.org/r/66384/diff/1/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> David Forsythe
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message