mesos-reviews mailing list archives: March 2018

Site index · List index
Message list« Previous · 1 · 2 · 3 · 4 · 5 · 6 · 7 · Next »Thread · Author · Date
Re: Review Request 53267: Added log and counter for tracking subscribers.
Zhitao Li   Re: Review Request 53267: Added log and counter for tracking subscribers. Tue, 20 Mar, 00:06
Mesos Reviewbot Windows     Re: Review Request 53267: Added log and counter for tracking subscribers. Tue, 20 Mar, 01:02
Re: Review Request 65640: Fixed leaks and a race condition in `UriDiskProfileAdaptorTests`.
Chun-Hung Hsiao   Re: Review Request 65640: Fixed leaks and a race condition in `UriDiskProfileAdaptorTests`. Tue, 20 Mar, 03:23
Re: Review Request 65962: Avoided copying `Owned` pointers in the default executor.
Alexander Rukletsov   Re: Review Request 65962: Avoided copying `Owned` pointers in the default executor. Tue, 20 Mar, 13:05
Gaston Kleiman     Re: Review Request 65962: Avoided copying `Owned` pointers in the default executor. Tue, 20 Mar, 21:51
Gaston Kleiman   Re: Review Request 65962: Avoided copying `Owned` pointers in the default executor. Wed, 21 Mar, 21:13
Alexander Rukletsov     Re: Review Request 65962: Avoided copying `Owned` pointers in the default executor. Thu, 22 Mar, 13:13
Gaston Kleiman       Re: Review Request 65962: Avoided copying `Owned` pointers in the default executor. Fri, 23 Mar, 02:13
Alexander Rukletsov     Re: Review Request 65962: Avoided copying `Owned` pointers in the default executor. Mon, 26 Mar, 16:28
Harold Dost Review Request 66173: Add test for new `disk/xfs` kill functionality. Tue, 20 Mar, 14:34
Mesos Reviewbot Windows   Re: Review Request 66173: Add test for new `disk/xfs` kill functionality. Tue, 20 Mar, 15:39
Harold Dost   Re: Review Request 66173: Add test for new `disk/xfs` kill functionality. Thu, 22 Mar, 14:11
Mesos Reviewbot Windows     Re: Review Request 66173: Add test for new `disk/xfs` kill functionality. Thu, 22 Mar, 16:04
James Peach     Re: Review Request 66173: Add test for new `disk/xfs` kill functionality. Thu, 22 Mar, 18:31
Mesos Reviewbot     Re: Review Request 66173: Add test for new `disk/xfs` kill functionality. Thu, 22 Mar, 23:39
James Peach     Re: Review Request 66173: Add test for new `disk/xfs` kill functionality. Tue, 27 Mar, 18:44
Re: Review Request 66158: libprocess: Made tests `GRPCClientTest.*` cross-platform.
Benjamin Bannier   Re: Review Request 66158: libprocess: Made tests `GRPCClientTest.*` cross-platform. Tue, 20 Mar, 15:59
Chun-Hung Hsiao     Re: Review Request 66158: libprocess: Made tests `GRPCClientTest.*` cross-platform. Tue, 20 Mar, 21:46
Benjamin Bannier     Re: Review Request 66158: Libprocess: Made tests `GRPCClientTest.*` cross-platform. Wed, 21 Mar, 20:13
Chun-Hung Hsiao   Re: Review Request 66158: Libprocess: Made tests `GRPCClientTest.*` cross-platform. Tue, 20 Mar, 22:46
Chun-Hung Hsiao     Re: Review Request 66158: Libprocess: Made tests `GRPCClientTest.*` cross-platform. Wed, 21 Mar, 20:25
Review Request 66175: Added isolator checks for namespaces support.
James Peach   Review Request 66175: Added isolator checks for namespaces support. Tue, 20 Mar, 16:51
Mesos Reviewbot Windows     Re: Review Request 66175: Added isolator checks for namespaces support. Tue, 20 Mar, 18:02
Mesos Reviewbot     Re: Review Request 66175: Added isolator checks for namespaces support. Tue, 20 Mar, 19:52
Andrew Schwartzmeyer   Re: Review Request 66175: Added isolator checks for namespaces support. Tue, 20 Mar, 20:18
James Peach     Re: Review Request 66175: Added isolator checks for namespaces support. Tue, 20 Mar, 20:23
Andrei Budnik Review Request 66177: Fixed flakiness in ROOT_DOCKER_SlaveRecoveryTaskContainer test. Tue, 20 Mar, 18:35
Mesos Reviewbot Windows   Re: Review Request 66177: Fixed flakiness in ROOT_DOCKER_SlaveRecoveryTaskContainer test. Tue, 20 Mar, 20:55
Mesos Reviewbot   Re: Review Request 66177: Fixed flakiness in ROOT_DOCKER_SlaveRecoveryTaskContainer test. Wed, 21 Mar, 00:51
Alexander Rukletsov   Re: Review Request 66177: Fixed flakiness in ROOT_DOCKER_SlaveRecoveryTaskContainer test. Wed, 21 Mar, 13:58
Meng Zhu Review Request 66178: Added a test to verify that task launch order is enforced. Tue, 20 Mar, 18:36
Mesos Reviewbot Windows   Re: Review Request 66178: Added a test to verify that task launch order is enforced. Tue, 20 Mar, 21:56
Mesos Reviewbot   Re: Review Request 66178: Added a test to verify that task launch order is enforced. Tue, 20 Mar, 22:30
Greg Mann   Re: Review Request 66178: Added a test to verify that task launch order is enforced. Wed, 21 Mar, 18:36
Meng Zhu   Re: Review Request 66178: Added a test to verify that task launch order is enforced. Wed, 21 Mar, 21:58
Mesos Reviewbot Windows     Re: Review Request 66178: Added a test to verify that task launch order is enforced. Wed, 21 Mar, 23:46
Mesos Reviewbot     Re: Review Request 66178: Added a test to verify that task launch order is enforced. Thu, 22 Mar, 01:45
Till Toenshoff Review Request 66165: Re-fixed many master allocator tests. Tue, 20 Mar, 20:36
Mesos Reviewbot Windows   Re: Review Request 66165: Re-fixed many master allocator tests. Tue, 20 Mar, 22:44
Mesos Reviewbot   Re: Review Request 66165: Re-fixed many master allocator tests. Wed, 21 Mar, 01:56
Alexander Rukletsov   Re: Review Request 66165: Re-fixed many master allocator tests. Wed, 21 Mar, 10:50
Alexander Rukletsov     Re: Review Request 66165: Re-fixed many master allocator tests. Wed, 21 Mar, 10:50
Benjamin Bannier   Re: Review Request 66165: Re-fixed many master allocator tests. Wed, 21 Mar, 10:52
Till Toenshoff Review Request 66164: Added to a comment in master.cpp. Tue, 20 Mar, 20:36
Alexander Rukletsov   Re: Review Request 66164: Added to a comment in master.cpp. Wed, 21 Mar, 17:21
Gaston Kleiman Review Request 66182: Fixed grammar errors in comments in SLRP tests. Tue, 20 Mar, 22:12
Greg Mann   Re: Review Request 66182: Fixed grammar errors in comments in SLRP tests. Tue, 20 Mar, 22:14
Mesos Reviewbot Windows   Re: Review Request 66182: Fixed grammar errors in comments in SLRP tests. Tue, 20 Mar, 23:46
Mesos Reviewbot   Re: Review Request 66182: Fixed grammar errors in comments in SLRP tests. Wed, 21 Mar, 04:02
Chun-Hung Hsiao   Re: Review Request 66182: Fixed grammar errors in comments in SLRP tests. Fri, 30 Mar, 01:13
Re: Review Request 63368: Added MemoryProfiler class to Libprocess.
Benno Evers   Re: Review Request 63368: Added MemoryProfiler class to Libprocess. Wed, 21 Mar, 19:52
Qian Zhang Review Request 66206: Used native protobuf map in Docker v1 image spec. Thu, 22 Mar, 06:56
Chun-Hung Hsiao   Re: Review Request 66206: Used native protobuf map in Docker v1 image spec. Thu, 22 Mar, 18:39
Qian Zhang     Re: Review Request 66206: Used native protobuf map in Docker v1 image spec. Fri, 23 Mar, 02:17
Gilbert Song     Re: Review Request 66206: Used native protobuf map in Docker v1 image spec. Wed, 28 Mar, 22:04
Gilbert Song   Re: Review Request 66206: Used native protobuf map in Docker v1 image spec. Wed, 28 Mar, 21:47
Qian Zhang Review Request 66207: Used native protobuf map in OCI v1 image spec. Thu, 22 Mar, 06:59
Mesos Reviewbot Windows   Re: Review Request 66207: Used native protobuf map in OCI v1 image spec. Thu, 22 Mar, 08:01
Mesos Reviewbot   Re: Review Request 66207: Used native protobuf map in OCI v1 image spec. Thu, 22 Mar, 09:00
Gilbert Song   Re: Review Request 66207: Used native protobuf map in OCI v1 image spec. Wed, 28 Mar, 22:23
Jan Schlicht Review Request 66210: Added OS_LINUX guard for 'test_csi_plugin'. Thu, 22 Mar, 09:37
Mesos Reviewbot Windows   Re: Review Request 66210: Added OS_LINUX guard for 'test_csi_plugin'. Thu, 22 Mar, 10:39
Alexander Rukletsov   Re: Review Request 66210: Added OS_LINUX guard for 'test_csi_plugin'. Thu, 22 Mar, 14:27
Jan Schlicht     Re: Review Request 66210: Added OS_LINUX guard for 'test_csi_plugin'. Thu, 22 Mar, 14:49
Chun-Hung Hsiao   Re: Review Request 66210: Added OS_LINUX guard for 'test_csi_plugin'. Thu, 22 Mar, 15:49
Mesos Reviewbot   Re: Review Request 66210: Added OS_LINUX guard for 'test_csi_plugin'. Thu, 22 Mar, 21:17
Qian Zhang Review Request 66211: Added the fields `ExposedPorts` and `Volumes` into Docker v1 image spec. Thu, 22 Mar, 09:47
Gilbert Song   Re: Review Request 66211: Added the fields `ExposedPorts` and `Volumes` into Docker v1 image spec. Wed, 28 Mar, 22:32
Qian Zhang Review Request 66212: Updated `ParseV1ImageManifest` to check `Volumes` and `ExposedPorts`. Thu, 22 Mar, 09:47
Mesos Reviewbot Windows   Re: Review Request 66212: Updated `ParseV1ImageManifest` to check `Volumes` and `ExposedPorts`. Thu, 22 Mar, 11:40
Review Request 66218: Ensured that agent does not delete volume upon grow or shrink.
Zhitao Li   Review Request 66218: Ensured that agent does not delete volume upon grow or shrink. Thu, 22 Mar, 16:28
Chun-Hung Hsiao   Re: Review Request 66218: Ensured that agent does not delete volume upon grow or shrink. Tue, 27 Mar, 01:29
Zhitao Li   Re: Review Request 66218: Ensured that agent does not delete volume upon grow or shrink. Tue, 27 Mar, 06:36
Chun-Hung Hsiao     Re: Review Request 66218: Ensured that agent does not delete volume upon grow or shrink. Tue, 27 Mar, 19:14
Zhitao Li       Re: Review Request 66218: Ensured that agent does not delete volume upon grow or shrink. Tue, 27 Mar, 22:37
Zhitao Li     Re: Review Request 66218: Ensured that agent does not delete volume upon grow or shrink. Wed, 28 Mar, 18:25
Review Request 66219: Added helper functions to create grow and shrink volume in test.
Zhitao Li   Review Request 66219: Added helper functions to create grow and shrink volume in test. Thu, 22 Mar, 16:29
Chun-Hung Hsiao   Re: Review Request 66219: Added helper functions to create grow and shrink volume in test. Tue, 27 Mar, 02:03
Zhitao Li   Re: Review Request 66219: Added helper functions to create grow and shrink volume in test. Tue, 27 Mar, 06:38
Review Request 66220: Added test for `GROW_VOLUME` and `SHRINK_VOLUME` operations.
Zhitao Li   Review Request 66220: Added test for `GROW_VOLUME` and `SHRINK_VOLUME` operations. Thu, 22 Mar, 16:30
Mesos Reviewbot Windows     Re: Review Request 66220: Added test for `GROW_VOLUME` and `SHRINK_VOLUME` operations. Thu, 22 Mar, 17:48
Zhitao Li   Re: Review Request 66220: Added test for `GROW_VOLUME` and `SHRINK_VOLUME` operations. Wed, 28 Mar, 18:29
Review Request 66227: Added test for `GROW_VOLUME` and `SHRINK_VOLUME` operator API.
Zhitao Li   Review Request 66227: Added test for `GROW_VOLUME` and `SHRINK_VOLUME` operator API. Thu, 22 Mar, 20:35
Mesos Reviewbot Windows     Re: Review Request 66227: Added test for `GROW_VOLUME` and `SHRINK_VOLUME` operator API. Thu, 22 Mar, 21:35
Mesos Reviewbot Windows   Re: Review Request 66227: Added test for `GROW_VOLUME` and `SHRINK_VOLUME` operator API. Thu, 29 Mar, 11:39
Kapil Arya Review Request 66228: Added call/event for updating framework info. Thu, 22 Mar, 20:53
Kapil Arya Review Request 66229: Implemented UPDATE_FRAMEWORK call. Thu, 22 Mar, 20:53
Kapil Arya Review Request 66230: Added test for adding/removing framework roles. Thu, 22 Mar, 20:53
Mesos Reviewbot Windows   Re: Review Request 66230: Added test for adding/removing framework roles. Thu, 22 Mar, 21:36
Mesos Reviewbot Windows   Re: Review Request 66230: Added test for adding/removing framework roles. Thu, 22 Mar, 22:54
Gaston Kleiman Review Request 66223: WIP. Fri, 23 Mar, 02:07
Gaston Kleiman Review Request 66232: Removed unnecessary/invalid checks from the default executor. Fri, 23 Mar, 02:10
Mesos Reviewbot Windows   Re: Review Request 66232: Removed unnecessary/invalid checks from the default executor. Fri, 23 Mar, 03:24
Gaston Kleiman   Re: Review Request 66232: Removed unnecessary/invalid checks from the default executor. Fri, 23 Mar, 17:49
Alexander Rukletsov     Re: Review Request 66232: Removed unnecessary/invalid checks from the default executor. Mon, 26 Mar, 15:57
Gaston Kleiman Review Request 66233: Made the default executor log kill failures. Fri, 23 Mar, 02:13
Alexander Rukletsov   Re: Review Request 66233: Made the default executor log kill failures. Mon, 26 Mar, 16:28
Gaston Kleiman Review Request 66234: Fixed variable shadowing in the default executor. Fri, 23 Mar, 02:14
Alexander Rukletsov   Re: Review Request 66234: Fixed variable shadowing in the default executor. Mon, 26 Mar, 16:28
Gaston Kleiman   Re: Review Request 66234: Fixed variable shadowing in the default executor. Mon, 26 Mar, 17:39
Gaston Kleiman     Re: Review Request 66234: Fixed variable shadowing in the default executor. Tue, 27 Mar, 09:43
Gaston Kleiman Review Request 66235: Added a reference to MESOS-8557 to the default executor. Fri, 23 Mar, 02:17
Mesos Reviewbot Windows   Re: Review Request 66235: Added a reference to MESOS-8557 to the default executor. Fri, 23 Mar, 04:35
Mesos Reviewbot   Re: Review Request 66235: Added a reference to MESOS-8557 to the default executor. Fri, 23 Mar, 11:36
Alexander Rukletsov   Re: Review Request 66235: Added a reference to MESOS-8557 to the default executor. Mon, 26 Mar, 16:28
Gaston Kleiman   Re: Review Request 66235: Added a reference to MESOS-8557 to the default executor. Mon, 26 Mar, 17:40
Mesos Reviewbot Windows     Re: Review Request 66235: Added a reference to MESOS-8557 to the default executor. Mon, 26 Mar, 18:33
Mesos Reviewbot     Re: Review Request 66235: Added a reference to MESOS-8557 to the default executor. Mon, 26 Mar, 21:08
Re: Review Request 63733: Don't print full usage for invocation errors.
Benno Evers   Re: Review Request 63733: Don't print full usage for invocation errors. Fri, 23 Mar, 14:39
Mesos Reviewbot     Re: Review Request 63733: Don't print full usage for invocation errors. Fri, 23 Mar, 15:36
Mesos Reviewbot Windows     Re: Review Request 63733: Don't print full usage for invocation errors. Fri, 23 Mar, 16:21
Till Toenshoff     Re: Review Request 63733: Don't print full usage for invocation errors. Wed, 28 Mar, 15:38
Benno Evers Review Request 66248: Re-enabled SlaveTest.ChangeDomain. Fri, 23 Mar, 14:40
Mesos Reviewbot Windows   Re: Review Request 66248: Re-enabled SlaveTest.ChangeDomain. Fri, 23 Mar, 15:36
Mesos Reviewbot   Re: Review Request 66248: Re-enabled SlaveTest.ChangeDomain. Fri, 23 Mar, 19:50
Benno Evers   Re: Review Request 66248: Removed SlaveTest.ChangeDomain. Mon, 26 Mar, 16:09
Mesos Reviewbot Windows     Re: Review Request 66248: Removed SlaveTest.ChangeDomain. Mon, 26 Mar, 17:04
Alexander Rukletsov     Re: Review Request 66248: Removed SlaveTest.ChangeDomain. Mon, 26 Mar, 17:09
Mesos Reviewbot     Re: Review Request 66248: Removed SlaveTest.ChangeDomain. Mon, 26 Mar, 17:56
Armand Grillet Review Request 66256: Removed non minified third party JS library files. Fri, 23 Mar, 20:11
Benjamin Mahler   Re: Review Request 66256: Removed non minified third party JS library files. Sat, 24 Mar, 02:40
Armand Grillet Review Request 66257: Added licenses for third party JS libraries used by Web UI. Fri, 23 Mar, 20:13
Mesos Reviewbot Windows   Re: Review Request 66257: Added licenses for third party JS libraries used by Web UI. Fri, 23 Mar, 21:38
Benjamin Mahler   Re: Review Request 66257: Added licenses for third party JS libraries used by Web UI. Sat, 24 Mar, 02:39
Chun-Hung Hsiao Review Request 66255: Temporarily disabled CSI proto compilation when gRPC is disabled. Fri, 23 Mar, 20:29
Chun-Hung Hsiao   Re: Review Request 66255: Temporarily disabled CSI proto compilation when gRPC is disabled. Fri, 23 Mar, 20:44
Mesos Reviewbot Windows     Re: Review Request 66255: Temporarily disabled CSI proto compilation when gRPC is disabled. Fri, 23 Mar, 21:44
Mesos Reviewbot     Re: Review Request 66255: Temporarily disabled CSI proto compilation when gRPC is disabled. Sat, 24 Mar, 05:13
Zhitao Li     Re: Review Request 66255: Temporarily disabled CSI proto compilation when gRPC is disabled. Wed, 28 Mar, 19:28
Zhitao Li Review Request 66258: Added max_duration to `TaskInfo` and new reason for kill. Fri, 23 Mar, 20:51
Zhitao Li Review Request 66259: Added max_duration support to command executor. Fri, 23 Mar, 20:51
Zhitao Li Review Request 66260: Added test for max duration support in command executor. Fri, 23 Mar, 20:52
Mesos Reviewbot Windows   Re: Review Request 66260: Added test for max duration support in command executor. Fri, 23 Mar, 22:31
Mesos Reviewbot   Re: Review Request 66260: Added test for max duration support in command executor. Sat, 24 Mar, 07:35
Re: Review Request 65585: Improved documentation regarding the new CLI setup.
Armand Grillet   Re: Review Request 65585: Improved documentation regarding the new CLI setup. Sat, 24 Mar, 11:39
Re: Review Request 65705: Fixed CLI bootstrap script to work with long workspace paths.
Armand Grillet   Re: Review Request 65705: Fixed CLI bootstrap script to work with long workspace paths. Sat, 24 Mar, 11:39
Andrei Budnik Review Request 66278: Ensured correct termination order in IOSwitchboard's main function. Mon, 26 Mar, 12:48
Alexander Rukletsov   Re: Review Request 66278: Ensured correct termination order in IOSwitchboard's main function. Mon, 26 Mar, 13:03
Mesos Reviewbot Windows   Re: Review Request 66278: Ensured correct termination order in IOSwitchboard's main function. Mon, 26 Mar, 13:43
Message list« Previous · 1 · 2 · 3 · 4 · 5 · 6 · 7 · Next »Thread · Author · Date
Box list
Oct 201976
Sep 2019312
Aug 2019540
Jul 2019707
Jun 2019621
May 2019472
Apr 2019702
Mar 2019955
Feb 2019758
Jan 2019749
Dec 2018455
Nov 2018598
Oct 2018832
Sep 2018704
Aug 20181218
Jul 20181040
Jun 20181026
May 20181520
Apr 20181445
Mar 20181350
Feb 20181396
Jan 20181470
Dec 20171464
Nov 20171769
Oct 20171445
Sep 20171054
Aug 20171341
Jul 20171295
Jun 20171475
May 20171547
Apr 20171266
Mar 20172102
Feb 20171631
Jan 20171655
Dec 20161774
Nov 20162300
Oct 20162196
Sep 20162748
Aug 20162311
Jul 20163001
Jun 20163216
May 20162928
Apr 20163332
Mar 20164025
Feb 20162997
Jan 20163700
Dec 20152431
Nov 20152744
Oct 20152284
Sep 20152621
Aug 20152300
Jul 20152051
Jun 20152449
May 20151444
Apr 2015338