From reviews-return-75214-apmail-mesos-reviews-archive=mesos.apache.org@mesos.apache.org Fri Mar 23 22:31:58 2018 Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 8AD9C1792E for ; Fri, 23 Mar 2018 22:31:58 +0000 (UTC) Received: (qmail 22390 invoked by uid 500); 23 Mar 2018 22:31:58 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 22358 invoked by uid 500); 23 Mar 2018 22:31:58 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 22343 invoked by uid 99); 23 Mar 2018 22:31:57 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 23 Mar 2018 22:31:57 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id 46CFD1A0FDC; Fri, 23 Mar 2018 22:31:57 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 3.353 X-Spam-Level: *** X-Spam-Status: No, score=3.353 tagged_above=-999 required=6.31 tests=[HTML_MESSAGE=2, HTML_OBFUSCATE_10_20=1.162, KAM_LAZY_DOMAIN_SECURITY=1, MANY_SPAN_IN_TEXT=1, NORMAL_HTTP_TO_IP=0.001, RCVD_IN_DNSWL_MED=-2.3, T_RP_MATCHES_RCVD=-0.01, URI_NOVOWEL=0.5] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id Ui4V84mHgGSw; Fri, 23 Mar 2018 22:31:53 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id 04CD960D54; Fri, 23 Mar 2018 22:31:53 +0000 (UTC) Received: from reviews.apache.org (unknown [10.41.0.12]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id AC263E00E8; Fri, 23 Mar 2018 22:31:52 +0000 (UTC) Received: from reviews-vm2.apache.org (localhost [IPv6:::1]) by reviews.apache.org (ASF Mail Server at reviews-vm2.apache.org) with ESMTP id 70412C40A93; Fri, 23 Mar 2018 22:31:52 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============6789148096522951472==" MIME-Version: 1.0 Subject: Re: Review Request 66260: Added test for max duration support in command executor. From: Mesos Reviewbot Windows To: James Peach , Jason Lai Cc: Zhitao Li , Mesos Reviewbot Windows , mesos Date: Fri, 23 Mar 2018 22:31:52 -0000 Message-ID: <20180323223152.15512.21206@reviews-vm2.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Mesos Reviewbot Windows X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/66260/ X-Sender: Mesos Reviewbot Windows References: <20180323205213.15512.37914@reviews-vm2.apache.org> In-Reply-To: <20180323205213.15512.37914@reviews-vm2.apache.org> Reply-To: Mesos Reviewbot Windows X-ReviewRequest-Repository: mesos --===============6789148096522951472== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66260/#review199916 ----------------------------------------------------------- FAIL: Some of the unit tests failed. Please check the relevant logs. Reviews applied: `['66258', '66259', '66260']` Failed command: `Start-MesosCITesting` All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/66260 Relevant logs: - [mesos-tests-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/66260/logs/mesos-tests-stdout.log): ``` [ OK ] Endpoint/SlaveEndpointTest.NoAuthorizer/2 (119 ms) [----------] 9 tests from Endpoint/SlaveEndpointTest (1112 ms total) [----------] 2 tests from ContainerizerType/DefaultContainerDNSFlagTest [ RUN ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/0 [ OK ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/0 (33 ms) [ RUN ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/1 [ OK ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/1 (37 ms) [----------] 2 tests from ContainerizerType/DefaultContainerDNSFlagTest (72 ms total) [----------] 1 test from IsolationFlag/CpuIsolatorTest [ RUN ] IsolationFlag/CpuIsolatorTest.ROOT_UserCpuUsage/0 [ OK ] IsolationFlag/CpuIsolatorTest.ROOT_UserCpuUsage/0 (854 ms) [----------] 1 test from IsolationFlag/CpuIsolatorTest (879 ms total) [----------] 1 test from IsolationFlag/MemoryIsolatorTest [ RUN ] IsolationFlag/MemoryIsolatorTest.ROOT_MemUsage/0 [ OK ] IsolationFlag/MemoryIsolatorTest.ROOT_MemUsage/0 (730 ms) [----------] 1 test from IsolationFlag/MemoryIsolatorTest (756 ms total) [----------] Global test environment tear-down [==========] 951 tests from 94 test cases ran. (453157 ms total) [ PASSED ] 950 tests. [ FAILED ] 1 test, listed below: [ FAILED ] CommandExecutorCheckTest.CommandCheckTimeout 1 FAILED TEST YOU HAVE 215 DISABLED TESTS ``` - [mesos-tests-stderr.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/66260/logs/mesos-tests-stderr.log): ``` I0323 22:31:39.317957 7136 slave.cpp:3873] Shutting down framework 31df7ef4-0d63-49b1-acbd-8819c7106a6f-0000 I0323 22:31:39.317957 7164 master.cpp:10446] Updating the state of task 1d099e46-1c75-4a25-8baf-29054289a09b of framework 31df7ef4I0323 22:31:39.140944 1756 exec.cpp:162] Version: 1.6.0 I0323 22:31:39.166954 6068 exec.cpp:236] Executor registered on agent 31df7ef4-0d63-49b1-acbd-8819c7106a6f-S0 I0323 22:31:39.170991 6440 executor.cpp:176] Received SUBSCRIBED event I0323 22:31:39.175979 6440 executor.cpp:180] Subscribed executor on winbldsrv-01.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net I0323 22:31:39.176986 6440 executor.cpp:176] Received LAUNCH event I0323 22:31:39.180982 6440 executor.cpp:656] Starting task 1d099e46-1c75-4a25-8baf-29054289a09b I0323 22:31:39.260988 6440 executor.cpp:483] Running 'D:\DCOS\mesos\src\mesos-containerizer.exe launch ' I0323 22:31:39.292974 6440 executor.cpp:669] Forked command at 6896 I0323 22:31:39.319953 9572 exec.cpp:445] Executor asked to shutdown I0323 22:31:39.322062 6792 executor.cpp:176] Received SHUTDOWN event I0323 22:31:39.322062 6792 executor.cpp:773] Shutting down I0323 22:31:39.322062 6792 executor.cpp:884] Sending SIGTERM to process tree at pid 6-0d63-49b1-acbd-8819c7106a6f-0000 (latest state: TASK_KILLED, status update state: TASK_KILLED) I0323 22:31:39.317957 7136 slave.cpp:6566] Shutting down executor '1d099e46-1c75-4a25-8baf-29054289a09b' of framework 31df7ef4-0d63-49b1-acbd-8819c7106a6f-0000 at executor(1)@10.3.1.8:56910 I0323 22:31:39.319953 7136 slave.cpp:919] Agent terminating W0323 22:31:39.319953 7136 slave.cpp:3869] Ignoring shutdown framework 31df7ef4-0d63-49b1-acbd-8819c7106a6f-0000 because it is terminating I0323 22:31:39.322062 7164 master.cpp:10545] Removing task 1d099e46-1c75-4a25-8baf-29054289a09b with resources cpus(allocated: *):4; mem(allocated: *):2048; disk(allocated: *):1024; ports(allocated: *):[31000-32000] of framework 31df7ef4-0d63-49b1-acbd-8819c7106a6f-0000 on agent 31df7ef4-0d63-49b1-acbd-8819c7106a6f-S0 at slave(420)@10.3.1.8:56889 (winbldsrv-01.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net) I0323 22:31:39.323974 7136 containerizer.cpp:2338] Destroying container 2210c917-87d9-4c26-b080-602e84c35bbf in RUNNING state I0323 22:31:39.323974 7164 master.cpp:1295] Agent 31df7ef4-0d63-49b1-acbd-8819c7106a6f-S0 at slave(420)@10.3.1.8:56889 (winbldsrv-01.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net) disconnected I0323 22:31:39.324966 7164 master.cpp:3283] Disconnecting agent 31df7ef4-0d63-49b1-acbd-8819c7106a6f-S0 at slave(420)@10.3.1.8:56889 (winbldsrv-01.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net) I0323 22:31:39.324966 7136 containerizer.cpp:2952] Transitioning the state of container 2210c917-87d9-4c26-b080-602e84c35bbf from RUNNING to DESTROYING I0323 22:31:39.324966 7164 master.cpp:3302] Deactivating agent 31df7ef4-0d63-49b1-acbd-8819c7106a6f-S0 at slave(420)@10.3.1.8:56889 (winbldsrv-01.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net) I0323 22:31:39.325992 7136 launcher.cpp:156] Asked to destroy container 2210c917-87d9-4c26-b080-602e84c35bbf I0323 22:31:39.325992 10036 hierarchical.cpp:344] Removed framework 31df7ef4-0d63-49b1-acbd-8819c7106a6f-0000 I0323 22:31:39.325992 10036 hierarchical.cpp:766] Agent 31df7ef4-0d63-49b1-acbd-8819c7106a6f-S0 deactivated I0323 22:31:39.341245 5240 containerizer.cpp:2791] Container 2210c917-87d9-4c26-b080-602e84c35bbf has exited I0323 22:31:39.374238 7492 master.cpp:1137] Master terminating I0323 22:31:39.376235 10048 hierarchical.cpp:609] Removed agent 31df7ef4-0d63-49b1-acbd-8819c7106a6f-S0 I0323 22:31:39.739245 10232 process.cpp:929] Stopped the socket accept loop ``` - Mesos Reviewbot Windows On March 23, 2018, 8:52 p.m., Zhitao Li wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/66260/ > ----------------------------------------------------------- > > (Updated March 23, 2018, 8:52 p.m.) > > > Review request for mesos, Jason Lai and James Peach. > > > Bugs: MESOS-8725 > https://issues.apache.org/jira/browse/MESOS-8725 > > > Repository: mesos > > > Description > ------- > > Added test for max duration support in command executor. > > > Diffs > ----- > > src/tests/command_executor_tests.cpp 3c5687f918deb8cdda8a97abb0fbd8d9b089926a > > > Diff: https://reviews.apache.org/r/66260/diff/1/ > > > Testing > ------- > > > Thanks, > > Zhitao Li > > --===============6789148096522951472==--