From reviews-return-75115-apmail-mesos-reviews-archive=mesos.apache.org@mesos.apache.org Thu Mar 22 14:11:10 2018 Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 35F8018954 for ; Thu, 22 Mar 2018 14:11:10 +0000 (UTC) Received: (qmail 78412 invoked by uid 500); 22 Mar 2018 14:11:09 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 78334 invoked by uid 500); 22 Mar 2018 14:11:09 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 77916 invoked by uid 99); 22 Mar 2018 14:11:08 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 22 Mar 2018 14:11:08 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 084E5C00EF; Thu, 22 Mar 2018 14:11:08 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 2.141 X-Spam-Level: ** X-Spam-Status: No, score=2.141 tagged_above=-999 required=6.31 tests=[DKIM_ADSP_CUSTOM_MED=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.25, HTML_MESSAGE=2, KAM_LAZY_DOMAIN_SECURITY=1, NML_ADSP_CUSTOM_MED=1.2, RCVD_IN_DNSWL_MED=-2.3, T_RP_MATCHES_RCVD=-0.01] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id 23cXY6TSiQ9I; Thu, 22 Mar 2018 14:11:03 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id 3EA145FE0E; Thu, 22 Mar 2018 14:11:02 +0000 (UTC) Received: from reviews.apache.org (unknown [10.41.0.12]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id B1F5DE0D0B; Thu, 22 Mar 2018 14:11:01 +0000 (UTC) Received: from reviews-vm2.apache.org (localhost [IPv6:::1]) by reviews.apache.org (ASF Mail Server at reviews-vm2.apache.org) with ESMTP id BD607C40775; Thu, 22 Mar 2018 14:11:00 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============1332630252203816942==" MIME-Version: 1.0 Subject: Re: Review Request 65571: Handle 'None' passed from the MasterDetector in 'Master::detect()'. From: Alexander Rukletsov To: Andrei Budnik , Alexander Rukletsov Cc: Mesos Reviewbot , Mesos Reviewbot Windows , mesos , Benno Evers , Vinod Kone Date: Thu, 22 Mar 2018 14:11:00 -0000 Message-ID: <20180322141100.34435.2068@reviews-vm2.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Alexander Rukletsov X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/65571/ X-Sender: Alexander Rukletsov References: <20180322140843.34434.21151@reviews-vm2.apache.org> In-Reply-To: <20180322140843.34434.21151@reviews-vm2.apache.org> Reply-To: Alexander Rukletsov X-ReviewRequest-Repository: mesos --===============1332630252203816942== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit > On March 22, 2018, 2:08 p.m., Alexander Rukletsov wrote: > > Ship It! Please use past simple in Summary for consistency. - Alexander ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65571/#review199760 ----------------------------------------------------------- On March 22, 2018, 12:06 p.m., Benno Evers wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/65571/ > ----------------------------------------------------------- > > (Updated March 22, 2018, 12:06 p.m.) > > > Review request for mesos, Andrei Budnik and Alexander Rukletsov. > > > Bugs: MESOS-8550 > https://issues.apache.org/jira/browse/MESOS-8550 > > > Repository: mesos > > > Description > ------- > > The function `MasterDetector::detect()` returns a value of type > `Future>`, which, according to its documentation, > can be `None` if an election occured and no master is elected. > > However, the code in `Master::detected()` was only handling the > cases of a failed future or a valid `MasterInfo` object. > > *NOTE*: This commit does not add a corresponding unit test, since > that would require starting a non-leading master. For the > ZooKeeperMasterDetector, this is blocked by MESOS-2976, and an API > change to make this possible with the StandaloneMasterDetector > would add a lot of complexity to the `cluster::Master::start()` > function for a feature that is unlikely to be re-used in any other > test. > > > Diffs > ----- > > src/master/master.cpp f0affa09dcf41b6a800e18105ad047bcffdfd3ec > > > Diff: https://reviews.apache.org/r/65571/diff/5/ > > > Testing > ------- > > `./mesos-tests` (See also last paragraph in description) > > > Thanks, > > Benno Evers > > --===============1332630252203816942==--