From reviews-return-75080-apmail-mesos-reviews-archive=mesos.apache.org@mesos.apache.org Wed Mar 21 20:25:15 2018 Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id F310318199 for ; Wed, 21 Mar 2018 20:25:14 +0000 (UTC) Received: (qmail 82800 invoked by uid 500); 21 Mar 2018 20:25:14 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 82768 invoked by uid 500); 21 Mar 2018 20:25:14 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 82753 invoked by uid 99); 21 Mar 2018 20:25:14 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 21 Mar 2018 20:25:14 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id C4907180518; Wed, 21 Mar 2018 20:25:13 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.939 X-Spam-Level: X-Spam-Status: No, score=0.939 tagged_above=-999 required=6.31 tests=[HEADER_FROM_DIFFERENT_DOMAINS=0.249, HTML_MESSAGE=2, KAM_LAZY_DOMAIN_SECURITY=1, RCVD_IN_DNSWL_MED=-2.3, T_RP_MATCHES_RCVD=-0.01] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id gtkIF4C1-sPv; Wed, 21 Mar 2018 20:25:12 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id 873105FDEF; Wed, 21 Mar 2018 20:25:12 +0000 (UTC) Received: from reviews.apache.org (unknown [10.41.0.12]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 32B6DE0253; Wed, 21 Mar 2018 20:25:12 +0000 (UTC) Received: from reviews-vm2.apache.org (localhost [IPv6:::1]) by reviews.apache.org (ASF Mail Server at reviews-vm2.apache.org) with ESMTP id ADD12C40360; Wed, 21 Mar 2018 20:25:11 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============0220398399374359638==" MIME-Version: 1.0 Subject: Re: Review Request 66158: Libprocess: Made tests `GRPCClientTest.*` cross-platform. From: Chun-Hung Hsiao To: Benjamin Bannier , Jie Yu , Joseph Wu , Andrew Schwartzmeyer Cc: Chun-Hung Hsiao , mesos Date: Wed, 21 Mar 2018 20:25:11 -0000 Message-ID: <20180321202511.64105.17231@reviews-vm2.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Chun-Hung Hsiao X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/66158/ X-Sender: Chun-Hung Hsiao References: <20180320224630.25996.64683@reviews-vm2.apache.org> In-Reply-To: <20180320224630.25996.64683@reviews-vm2.apache.org> Reply-To: Chun-Hung Hsiao X-ReviewRequest-Repository: mesos --===============0220398399374359638== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66158/ ----------------------------------------------------------- (Updated March 21, 2018, 8:25 p.m.) Review request for mesos, Andrew Schwartzmeyer, Benjamin Bannier, Jie Yu, and Joseph Wu. Changes ------- Made copying of `shared_ptr` in `Channel` constructor explicit. Bugs: MESOS-8697 https://issues.apache.org/jira/browse/MESOS-8697 Repository: mesos Description ------- The `GRPCClientTest.*` tests now uses in-process channels instead of Unix domain sockets, except for `DiscardedBeforeServerStarted`, which is disabled on Windowns for now. Diffs (updated) ----- 3rdparty/libprocess/include/process/grpc.hpp edaf0410c62454df53d06957a4a8f1f6027b00bb 3rdparty/libprocess/src/tests/grpc_tests.cpp 8bb517fb5659b7010a0fe8b7b90ebb3a5c9f1157 Diff: https://reviews.apache.org/r/66158/diff/3/ Changes: https://reviews.apache.org/r/66158/diff/2-3/ Testing ------- sudo make check NOTE: This is not tested on Windows yet. The CMake rules are added later in the chain. Thanks, Chun-Hung Hsiao --===============0220398399374359638==--