From reviews-return-75077-apmail-mesos-reviews-archive=mesos.apache.org@mesos.apache.org Wed Mar 21 19:52:13 2018 Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 42DE418002 for ; Wed, 21 Mar 2018 19:52:13 +0000 (UTC) Received: (qmail 5316 invoked by uid 500); 21 Mar 2018 19:52:13 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 5282 invoked by uid 500); 21 Mar 2018 19:52:13 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 5267 invoked by uid 99); 21 Mar 2018 19:52:12 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 21 Mar 2018 19:52:12 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 1587EC6237; Wed, 21 Mar 2018 19:52:12 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 1.189 X-Spam-Level: * X-Spam-Status: No, score=1.189 tagged_above=-999 required=6.31 tests=[HEADER_FROM_DIFFERENT_DOMAINS=0.249, HTML_MESSAGE=2, KAM_LAZY_DOMAIN_SECURITY=1, KAM_LOTSOFHASH=0.25, RCVD_IN_DNSWL_MED=-2.3, T_RP_MATCHES_RCVD=-0.01] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id a0mNhaJKjrEi; Wed, 21 Mar 2018 19:52:11 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id D64765FDC3; Wed, 21 Mar 2018 19:52:10 +0000 (UTC) Received: from reviews.apache.org (unknown [10.41.0.12]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 7E7EBE0253; Wed, 21 Mar 2018 19:52:10 +0000 (UTC) Received: from reviews-vm2.apache.org (localhost [IPv6:::1]) by reviews.apache.org (ASF Mail Server at reviews-vm2.apache.org) with ESMTP id 23437C40360; Wed, 21 Mar 2018 19:52:10 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============1159473728967641337==" MIME-Version: 1.0 Subject: Re: Review Request 63368: Added MemoryProfiler class to Libprocess. From: Benno Evers To: Benjamin Mahler , Alexander Rukletsov Cc: Mesos Reviewbot Windows , mesos , Benno Evers Date: Wed, 21 Mar 2018 19:52:10 -0000 Message-ID: <20180321195210.64105.52595@reviews-vm2.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Benno Evers X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/63368/ X-Sender: Benno Evers References: <20180221104117.27952.55103@reviews-vm2.apache.org> In-Reply-To: <20180221104117.27952.55103@reviews-vm2.apache.org> X-ReviewBoard-Diff-For: 3rdparty/libprocess/include/process/memory_profiler.hpp X-ReviewBoard-Diff-For: 3rdparty/libprocess/src/memory_profiler.cpp Reply-To: Benno Evers X-ReviewRequest-Repository: mesos --===============1159473728967641337== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63368/ ----------------------------------------------------------- (Updated March 21, 2018, 7:52 p.m.) Review request for mesos, Alexander Rukletsov and Benjamin Mahler. Changes ------- Updated endpoints to return JSON. Repository: mesos Description ------- This class exposes profiling functionality of jemalloc memory allocator when it is detected to be the memory allocator of the current process. In particular, it gives developers an easy method to collect and access heap profiles which report which pieces of code were responsible for allocating memory. Diffs (updated) ----- 3rdparty/libprocess/Makefile.am c895d3ac7b9cc5ffd6c8b57ff24def866eb0213d 3rdparty/libprocess/include/process/memory_profiler.hpp PRE-CREATION 3rdparty/libprocess/include/process/process.hpp 95a82973644553e0a1c2bdef9121f17bf18b4fcc 3rdparty/libprocess/src/CMakeLists.txt 0ce7dac5deea94623530820d173ce3ffe5b42ea4 3rdparty/libprocess/src/memory_profiler.cpp PRE-CREATION 3rdparty/libprocess/src/process.cpp 42e7adf740b234ebf23d2dcb71440749c0ed87ec Diff: https://reviews.apache.org/r/63368/diff/7/ Changes: https://reviews.apache.org/r/63368/diff/6-7/ Testing ------- Thanks, Benno Evers --===============1159473728967641337==--