From reviews-return-75064-apmail-mesos-reviews-archive=mesos.apache.org@mesos.apache.org Wed Mar 21 13:58:59 2018 Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id A410517EDC for ; Wed, 21 Mar 2018 13:58:59 +0000 (UTC) Received: (qmail 656 invoked by uid 500); 21 Mar 2018 13:58:54 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 624 invoked by uid 500); 21 Mar 2018 13:58:54 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 613 invoked by uid 99); 21 Mar 2018 13:58:53 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 21 Mar 2018 13:58:53 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id 79E7018088F; Wed, 21 Mar 2018 13:58:53 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 2.14 X-Spam-Level: ** X-Spam-Status: No, score=2.14 tagged_above=-999 required=6.31 tests=[DKIM_ADSP_CUSTOM_MED=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.249, HTML_MESSAGE=2, KAM_LAZY_DOMAIN_SECURITY=1, NML_ADSP_CUSTOM_MED=1.2, RCVD_IN_DNSWL_MED=-2.3, T_RP_MATCHES_RCVD=-0.01] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id Se83fGflEqUt; Wed, 21 Mar 2018 13:58:52 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id 4F26A5F17B; Wed, 21 Mar 2018 13:58:52 +0000 (UTC) Received: from reviews.apache.org (unknown [10.41.0.12]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id BFF7CE0253; Wed, 21 Mar 2018 13:58:51 +0000 (UTC) Received: from reviews-vm2.apache.org (localhost [IPv6:::1]) by reviews.apache.org (ASF Mail Server at reviews-vm2.apache.org) with ESMTP id 3434FC407C0; Wed, 21 Mar 2018 13:58:51 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============0836277293824122173==" MIME-Version: 1.0 Subject: Re: Review Request 66177: Fixed flakiness in ROOT_DOCKER_SlaveRecoveryTaskContainer test. From: Alexander Rukletsov To: Alexander Rukletsov , Benno Evers Cc: Andrei Budnik , mesos Date: Wed, 21 Mar 2018 13:58:50 -0000 Message-ID: <20180321135850.64105.65322@reviews-vm2.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Alexander Rukletsov X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/66177/ X-Sender: Alexander Rukletsov X-ReviewBoard-ShipIt: 1 References: <20180320183529.25997.55529@reviews-vm2.apache.org> In-Reply-To: <20180320183529.25997.55529@reviews-vm2.apache.org> X-ReviewBoard-ShipIt-Only: 1 Reply-To: Alexander Rukletsov X-ReviewRequest-Repository: mesos --===============0836277293824122173== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66177/#review199661 ----------------------------------------------------------- Ship it! Ship It! - Alexander Rukletsov On March 20, 2018, 6:35 p.m., Andrei Budnik wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/66177/ > ----------------------------------------------------------- > > (Updated March 20, 2018, 6:35 p.m.) > > > Review request for mesos, Alexander Rukletsov and Benno Evers. > > > Bugs: MESOS-8258 > https://issues.apache.org/jira/browse/MESOS-8258 > > > Repository: mesos > > > Description > ------- > > The test was flaky due to ignoring only TASK_STARTING status update, > while TASK_RUNNING status update might appear if a task was launched > before the Docker executor re-registered. To fix the issue, this patch > ensures that both status updates are received. > > > Diffs > ----- > > src/tests/containerizer/docker_containerizer_tests.cpp 080270281f77fc8732148e69f4d287074c66853e > > > Diff: https://reviews.apache.org/r/66177/diff/1/ > > > Testing > ------- > > ./src/mesos-tests --gtest_filter=DockerContainerizerTest.ROOT_DOCKER_SlaveRecoveryTaskContainer --gtest_break_on_failure --gtest_repeat=100 > > > Thanks, > > Andrei Budnik > > --===============0836277293824122173==--