From reviews-return-75002-apmail-mesos-reviews-archive=mesos.apache.org@mesos.apache.org Tue Mar 20 20:18:29 2018 Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 3E52F18942 for ; Tue, 20 Mar 2018 20:18:29 +0000 (UTC) Received: (qmail 97859 invoked by uid 500); 20 Mar 2018 20:18:29 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 97845 invoked by uid 500); 20 Mar 2018 20:18:29 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 97834 invoked by uid 99); 20 Mar 2018 20:18:28 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 20 Mar 2018 20:18:28 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 04E81C1008; Tue, 20 Mar 2018 20:18:28 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 1.189 X-Spam-Level: * X-Spam-Status: No, score=1.189 tagged_above=-999 required=6.31 tests=[HEADER_FROM_DIFFERENT_DOMAINS=0.249, HTML_MESSAGE=2, KAM_LAZY_DOMAIN_SECURITY=1, KAM_LOTSOFHASH=0.25, RCVD_IN_DNSWL_MED=-2.3, T_RP_MATCHES_RCVD=-0.01] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id kIfSABirUvXX; Tue, 20 Mar 2018 20:18:26 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id 196A15F178; Tue, 20 Mar 2018 20:18:26 +0000 (UTC) Received: from reviews.apache.org (unknown [10.41.0.12]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 81B26E0056; Tue, 20 Mar 2018 20:18:25 +0000 (UTC) Received: from reviews-vm2.apache.org (localhost [IPv6:::1]) by reviews.apache.org (ASF Mail Server at reviews-vm2.apache.org) with ESMTP id 48477C40518; Tue, 20 Mar 2018 20:18:25 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============0812726298870979339==" MIME-Version: 1.0 Subject: Re: Review Request 66175: Added isolator checks for namespaces support. From: Andrew Schwartzmeyer To: Jie Yu , Andrew Schwartzmeyer Cc: James Peach , mesos Date: Tue, 20 Mar 2018 20:18:25 -0000 Message-ID: <20180320201825.25997.89031@reviews-vm2.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Andrew Schwartzmeyer X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/66175/ X-Sender: Andrew Schwartzmeyer X-ReviewBoard-ShipIt: 1 References: <20180320201303.25997.80353@reviews-vm2.apache.org> In-Reply-To: <20180320201303.25997.80353@reviews-vm2.apache.org> Reply-To: Andrew Schwartzmeyer X-ReviewRequest-Repository: mesos --===============0812726298870979339== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66175/#review199574 ----------------------------------------------------------- Fix it, then Ship it! src/slave/containerizer/mesos/isolators/docker/volume/isolator.cpp Lines 91-94 (patched) Just one question: under what scenarios does `ns::supported` return an error? I ask because this might lead to misleading error messages. src/slave/containerizer/mesos/isolators/filesystem/shared.cpp Line 59 (original), 59 (patched) // TODO(andschwa): Write a cross-platform `os::is_root()` function... - Andrew Schwartzmeyer On March 20, 2018, 1:13 p.m., James Peach wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/66175/ > ----------------------------------------------------------- > > (Updated March 20, 2018, 1:13 p.m.) > > > Review request for mesos, Andrew Schwartzmeyer and Jie Yu. > > > Bugs: MESOS-6555 > https://issues.apache.org/jira/browse/MESOS-6555 > > > Repository: mesos > > > Description > ------- > > Some isolators assumed that the Linux namespaces they needed were > supported but did not explicitly check for them. Added explicit > checks for the required namespaces so that the isolators can emit > a more specifc error message. > > > Diffs > ----- > > src/slave/containerizer/mesos/isolators/docker/volume/isolator.cpp a6f05a8cf7eab2b2cc4c2142efdf3125462ec68e > src/slave/containerizer/mesos/isolators/filesystem/linux.cpp 6ee249997fcdfa37f7d073d9c150d06908b3f921 > src/slave/containerizer/mesos/isolators/filesystem/shared.cpp 118f39871fd76ca00b92e4fa80c698a2a8f02f19 > src/slave/containerizer/mesos/isolators/network/cni/cni.cpp d8dc02a686603e8f5dca073084c09992270b7f42 > > > Diff: https://reviews.apache.org/r/66175/diff/1/ > > > Testing > ------- > > make check (Fedora 27) > > > Thanks, > > James Peach > > --===============0812726298870979339==--