From reviews-return-74909-apmail-mesos-reviews-archive=mesos.apache.org@mesos.apache.org Mon Mar 19 18:42:34 2018 Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 1482E180F8 for ; Mon, 19 Mar 2018 18:42:34 +0000 (UTC) Received: (qmail 86735 invoked by uid 500); 19 Mar 2018 18:42:34 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 86703 invoked by uid 500); 19 Mar 2018 18:42:33 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 86681 invoked by uid 99); 19 Mar 2018 18:42:33 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 19 Mar 2018 18:42:33 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id D46DD18038B; Mon, 19 Mar 2018 18:42:32 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.939 X-Spam-Level: X-Spam-Status: No, score=0.939 tagged_above=-999 required=6.31 tests=[HEADER_FROM_DIFFERENT_DOMAINS=0.249, HTML_MESSAGE=2, KAM_LAZY_DOMAIN_SECURITY=1, RCVD_IN_DNSWL_MED=-2.3, T_RP_MATCHES_RCVD=-0.01] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id yQoKSCKCUCqr; Mon, 19 Mar 2018 18:42:31 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id 6A2A35F571; Mon, 19 Mar 2018 18:42:31 +0000 (UTC) Received: from reviews.apache.org (unknown [10.41.0.12]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id BA334E0047; Mon, 19 Mar 2018 18:42:30 +0000 (UTC) Received: from reviews-vm2.apache.org (localhost [IPv6:::1]) by reviews.apache.org (ASF Mail Server at reviews-vm2.apache.org) with ESMTP id 88A85C405C3; Mon, 19 Mar 2018 18:42:30 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============1713963427575054836==" MIME-Version: 1.0 Subject: Review Request 66145: Added a test to verify that task launch order is enforced. From: Meng Zhu To: Chun-Hung Hsiao , Greg Mann Cc: Meng Zhu , mesos Date: Mon, 19 Mar 2018 18:42:30 -0000 Message-ID: <20180319184230.52218.8685@reviews-vm2.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Meng Zhu X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/66145/ X-Sender: Meng Zhu Reply-To: Meng Zhu X-ReviewRequest-Repository: mesos --===============1713963427575054836== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66145/ ----------------------------------------------------------- Review request for mesos, Chun-Hung Hsiao and Greg Mann. Bugs: MESOS-8624 https://issues.apache.org/jira/browse/MESOS-8624 Repository: mesos Description ------- Agent should launch the task in their receiving order. On the task launch path, there are currently two asynchronous steps which may complete out of order: unschedule GC and task authorization. This test simulates the reordering of the completions of unschedule GC step and verify that, despite the reordering, tasks can still launch in their original order. Diffs ----- src/tests/slave_tests.cpp f76500ebdb67f131a57a3b5aaae8c952d019e354 Diff: https://reviews.apache.org/r/66145/diff/1/ Testing ------- make check Thanks, Meng Zhu --===============1713963427575054836==--