From reviews-return-74788-apmail-mesos-reviews-archive=mesos.apache.org@mesos.apache.org Thu Mar 15 21:11:23 2018 Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id BE758104B0 for ; Thu, 15 Mar 2018 21:11:23 +0000 (UTC) Received: (qmail 22498 invoked by uid 500); 15 Mar 2018 21:11:23 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 22466 invoked by uid 500); 15 Mar 2018 21:11:23 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 22451 invoked by uid 99); 15 Mar 2018 21:11:22 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 15 Mar 2018 21:11:22 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id 927E7C046E; Thu, 15 Mar 2018 21:11:22 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 2.142 X-Spam-Level: ** X-Spam-Status: No, score=2.142 tagged_above=-999 required=6.31 tests=[DKIM_ADSP_CUSTOM_MED=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.001, HTML_MESSAGE=2, KAM_LAZY_DOMAIN_SECURITY=1, KAM_LOTSOFHASH=0.25, NML_ADSP_CUSTOM_MED=1.2, RCVD_IN_DNSWL_MED=-2.3, T_RP_MATCHES_RCVD=-0.01] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id 1cuY27rDJnjn; Thu, 15 Mar 2018 21:11:21 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id C49255F175; Thu, 15 Mar 2018 21:11:20 +0000 (UTC) Received: from reviews.apache.org (unknown [10.41.0.12]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id EDDE7E0110; Thu, 15 Mar 2018 21:11:19 +0000 (UTC) Received: from reviews-vm2.apache.org (localhost [IPv6:::1]) by reviews.apache.org (ASF Mail Server at reviews-vm2.apache.org) with ESMTP id 7258CC41A41; Thu, 15 Mar 2018 21:11:19 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============4147491158937399229==" MIME-Version: 1.0 Subject: Review Request 66101: Added a helper to parse ContainerID. From: Jie Yu To: Sagar Patwardhan Cc: Jie Yu , mesos Date: Thu, 15 Mar 2018 21:11:19 -0000 Message-ID: <20180315211119.49979.38592@reviews-vm2.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Jie Yu X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/66101/ X-Sender: Jie Yu Reply-To: Jie Yu X-ReviewRequest-Repository: mesos --===============4147491158937399229== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66101/ ----------------------------------------------------------- Review request for mesos and Sagar Patwardhan. Bugs: MESOS-8534 https://issues.apache.org/jira/browse/MESOS-8534 Repository: mesos Description ------- Added a helper to parse ContainerID. Diffs ----- src/common/protobuf_utils.hpp b33d126eafb214e19911801500b241aa5e0e57b1 src/common/protobuf_utils.cpp e0609b6154409d24ee99365feeffbdabe90d4e67 src/tests/protobuf_utils_tests.cpp 5fd45566ee90e218847fe5f0bfb174ec0d6999b9 Diff: https://reviews.apache.org/r/66101/diff/1/ Testing ------- make check Thanks, Jie Yu --===============4147491158937399229==--