From reviews-return-74195-apmail-mesos-reviews-archive=mesos.apache.org@mesos.apache.org Fri Mar 2 19:31:18 2018 Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id A33531846C for ; Fri, 2 Mar 2018 19:31:18 +0000 (UTC) Received: (qmail 58141 invoked by uid 500); 2 Mar 2018 19:31:18 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 58105 invoked by uid 500); 2 Mar 2018 19:31:18 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 58090 invoked by uid 99); 2 Mar 2018 19:31:17 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 02 Mar 2018 19:31:17 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 5DCFEC167A; Fri, 2 Mar 2018 19:31:17 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.69 X-Spam-Level: X-Spam-Status: No, score=0.69 tagged_above=-999 required=6.31 tests=[HTML_MESSAGE=2, KAM_LAZY_DOMAIN_SECURITY=1, RCVD_IN_DNSWL_MED=-2.3, T_RP_MATCHES_RCVD=-0.01] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id TPfPh7tO5-h8; Fri, 2 Mar 2018 19:31:16 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id 24EEF5F39E; Fri, 2 Mar 2018 19:31:16 +0000 (UTC) Received: from reviews.apache.org (unknown [10.41.0.12]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id BEEABE00EA; Fri, 2 Mar 2018 19:31:15 +0000 (UTC) Received: from reviews-vm2.apache.org (localhost [IPv6:::1]) by reviews.apache.org (ASF Mail Server at reviews-vm2.apache.org) with ESMTP id 1A61CC404BB; Fri, 2 Mar 2018 19:31:14 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============3239407375973105209==" MIME-Version: 1.0 Subject: Re: Review Request 65886: Do not realpath executables from launcher_dir. From: Mesos Reviewbot To: Mesos Reviewbot , Benjamin Peterson , mesos Date: Fri, 02 Mar 2018 19:31:14 -0000 Message-ID: <20180302193114.527.31070@reviews-vm2.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Mesos Reviewbot X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/65886/ X-Sender: Mesos Reviewbot References: <20180302170340.526.15278@reviews-vm2.apache.org> In-Reply-To: <20180302170340.526.15278@reviews-vm2.apache.org> Reply-To: Mesos Reviewbot X-ReviewRequest-Repository: mesos --===============3239407375973105209== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65886/#review198542 ----------------------------------------------------------- Bad review! Reviews applied: [] Error: No reviewers specified. Please find a reviewer by asking on JIRA or the mailing list. - Mesos Reviewbot On March 2, 2018, 9:03 a.m., Benjamin Peterson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/65886/ > ----------------------------------------------------------- > > (Updated March 2, 2018, 9:03 a.m.) > > > Review request for mesos. > > > Repository: mesos > > > Description > ------- > > Mesos realpaths some helper executables (e.g., mesos-executor) but not > others (mesos-executor and mesos-fetcher) before executing them. I > don't see any reason for the inconsistency here, and not doing it > saves some code. > > > Diffs > ----- > > src/slave/containerizer/fetcher.cpp a49411b7bac2d5a50a75d0b802842c2f61fe58c6 > src/slave/slave.cpp e2facb3c15a2f907f6497c58a36842ed707f2c70 > > > Diff: https://reviews.apache.org/r/65886/diff/1/ > > > Testing > ------- > > `make check` passes. > > > Thanks, > > Benjamin Peterson > > --===============3239407375973105209==--