| James Peach |
Re: Review Request 66001: MESOS-6575: Add soft limit and kill to disk/xfs. |
Mon, 19 Mar, 17:44 |
| Gaston Kleiman |
Review Request 66142: Added blank lines after multi-line logging statements in `master.cpp`. |
Mon, 19 Mar, 18:08 |
| Gaston Kleiman |
Review Request 66141: Fixed whitespace in SLRP tests. |
Mon, 19 Mar, 18:08 |
| Gaston Kleiman |
Re: Review Request 66060: Added end-to-end tests for operation feedback. |
Mon, 19 Mar, 18:09 |
| Gaston Kleiman |
Re: Review Request 65994: Made the master forward operation status updates to the schedulers. |
Mon, 19 Mar, 18:11 |
| Gaston Kleiman |
Re: Review Request 64618: Implemented the master's `ACKNOWLEDGE_OPERATION_STATUS` handler. |
Mon, 19 Mar, 18:12 |
| Gaston Kleiman |
Re: Review Request 64618: Implemented the master's `ACKNOWLEDGE_OPERATION_STATUS` handler. |
Mon, 19 Mar, 18:13 |
| John Kordich via Review Board |
Re: Review Request 66002: Fixed the HTTP API path variables on Windows. |
Mon, 19 Mar, 18:20 |
| Meng Zhu |
Review Request 66144: Enforced task launch order on the agent. |
Mon, 19 Mar, 18:34 |
| Gaston Kleiman |
Review Request 66140: Fixed bug in `Framework::removeOperation()`. |
Mon, 19 Mar, 18:40 |
| Meng Zhu |
Review Request 66145: Added a test to verify that task launch order is enforced. |
Mon, 19 Mar, 18:42 |
| Meng Zhu |
Review Request 66126: Refactored agent task launch for better composition [1/2]. |
Mon, 19 Mar, 18:43 |
| Meng Zhu |
Review Request 66143: Refactored agent task launch for better composition [2/2]. |
Mon, 19 Mar, 18:43 |
| Andrei Budnik |
Review Request 66147: Fixed disconnection for ATTACH_CONTAINER_INPUT call in IOSwitchboard. |
Mon, 19 Mar, 19:00 |
| Mesos Reviewbot Windows |
Re: Review Request 66142: Added blank lines after multi-line logging statements in `master.cpp`. |
Mon, 19 Mar, 19:06 |
| Andrew Schwartzmeyer |
Re: Review Request 66008: CMake: Enabled compiler warnings. |
Mon, 19 Mar, 19:08 |
| Andrew Schwartzmeyer |
Re: Review Request 66009: CMake: Added `-Wno-unused-local-typedefs` to Boost interface. |
Mon, 19 Mar, 19:09 |
| Andrew Schwartzmeyer |
Re: Review Request 66010: Windows: Switched to default CRT linkage. |
Mon, 19 Mar, 19:12 |
| Andrew Schwartzmeyer |
Re: Review Request 66011: Windows: Set 3rdparty libraries to link to CRT dynamically. |
Mon, 19 Mar, 19:13 |
| Andrew Schwartzmeyer |
Re: Review Request 66012: CMake: Split `CMAKE_FORWARD_ARGS` into `C` and `CXX` versions. |
Mon, 19 Mar, 19:13 |
| Andrew Schwartzmeyer |
Re: Review Request 66013: Windows: Made ZooKeeper use default CRT linking. |
Mon, 19 Mar, 19:14 |
| Andrew Schwartzmeyer |
Re: Review Request 66046: CMake: Patched Boost to remove spurious warnings. |
Mon, 19 Mar, 19:14 |
| Zhitao Li |
Re: Review Request 66141: Fixed whitespace in SLRP tests. |
Mon, 19 Mar, 19:18 |
| Zhitao Li |
Re: Review Request 66142: Added blank lines after multi-line logging statements in `master.cpp`. |
Mon, 19 Mar, 19:19 |
| Andrew Schwartzmeyer |
Re: Review Request 66008: CMake: Enabled compiler warnings. |
Mon, 19 Mar, 19:36 |
| Mesos Reviewbot Windows |
Re: Review Request 65869: Removed unnecessary warning in agent `statusUpdate()`. |
Mon, 19 Mar, 20:02 |
| Mesos Reviewbot Windows |
Re: Review Request 66140: Fixed bug in `Framework::removeOperation()`. |
Mon, 19 Mar, 20:06 |
| Mesos Reviewbot |
Re: Review Request 66142: Added blank lines after multi-line logging statements in `master.cpp`. |
Mon, 19 Mar, 20:10 |
| Joseph Wu |
Re: Review Request 66011: Windows: Set 3rdparty libraries to link to CRT dynamically. |
Mon, 19 Mar, 20:15 |
| Joseph Wu |
Re: Review Request 66012: CMake: Split `CMAKE_FORWARD_ARGS` into `C` and `CXX` versions. |
Mon, 19 Mar, 20:16 |
| Joseph Wu |
Re: Review Request 66013: Windows: Made ZooKeeper use default CRT linking. |
Mon, 19 Mar, 20:18 |
| Joseph Wu |
Re: Review Request 66014: Windows: Made SASL use default CRT linking. |
Mon, 19 Mar, 20:18 |
| Joseph Wu |
Re: Review Request 66046: CMake: Patched Boost to remove spurious warnings. |
Mon, 19 Mar, 20:19 |
| Greg Mann |
Re: Review Request 65833: Displayed resource provider resources in GET_AGENTS response. |
Mon, 19 Mar, 20:20 |
| Zhitao Li |
Re: Review Request 66140: Fixed bug in `Framework::removeOperation()`. |
Mon, 19 Mar, 20:23 |
| Andrew Schwartzmeyer |
Review Request 66150: WIP: Add -Werror semantics to CMake. |
Mon, 19 Mar, 20:34 |
| Mesos Reviewbot Windows |
Re: Review Request 66147: Fixed disconnection for ATTACH_CONTAINER_INPUT call in IOSwitchboard. |
Mon, 19 Mar, 20:57 |
| Mesos Reviewbot Windows |
Re: Review Request 66145: Added a test to verify that task launch order is enforced. |
Mon, 19 Mar, 21:08 |
| Andrei Budnik |
Re: Review Request 66147: Fixed disconnection for ATTACH_CONTAINER_INPUT call in IOSwitchboard. |
Mon, 19 Mar, 21:41 |
| Mesos Reviewbot Windows |
Re: Review Request 66002: Fixed the HTTP API path variables on Windows. |
Mon, 19 Mar, 21:49 |
| Alexander Rukletsov |
Re: Review Request 66147: Fixed disconnection for ATTACH_CONTAINER_INPUT call in IOSwitchboard. |
Mon, 19 Mar, 21:52 |
| Mesos Reviewbot |
Re: Review Request 66002: Fixed the HTTP API path variables on Windows. |
Mon, 19 Mar, 22:11 |
| Greg Mann |
Re: Review Request 65832: Displayed resource provider resources in GET_RESOURCE_PROVIDER response. |
Mon, 19 Mar, 22:19 |
| Mesos Reviewbot Windows |
Re: Review Request 66150: WIP: Add -Werror semantics to CMake. |
Mon, 19 Mar, 22:43 |
| Gaston Kleiman |
Re: Review Request 66142: Added blank lines after multi-line logging statements in `master.cpp`. |
Mon, 19 Mar, 23:16 |
| Chun-Hung Hsiao |
Review Request 66156: Compiled `csi.proto` when gRPC is disabled. |
Mon, 19 Mar, 23:29 |
| Chun-Hung Hsiao |
Review Request 66157: Fixed header inclusions for `csi/spec.hpp`. |
Mon, 19 Mar, 23:29 |
| Greg Mann |
Re: Review Request 66058: Added v1 versions of some test helpers/matchers. |
Mon, 19 Mar, 23:30 |
| Chun-Hung Hsiao |
Review Request 66158: libprocess: Made tests `GRPCClientTest.*` cross-platform. |
Mon, 19 Mar, 23:38 |
| Chun-Hung Hsiao |
Review Request 66159: Made tests `CSIClientTest.*` cross-platform. |
Mon, 19 Mar, 23:41 |
| Greg Mann |
Re: Review Request 66059: Added a `SendAcknowledgeOperationStatus` test action. |
Mon, 19 Mar, 23:44 |
| Chun-Hung Hsiao |
Review Request 66160: Renamed `disk_profile` files to `disk_profile_adatpor`. |
Mon, 19 Mar, 23:46 |
| Chun-Hung Hsiao |
Review Request 66161: Renamed the internal namespace `profile` to `storage`. |
Mon, 19 Mar, 23:47 |
| Meng Zhu |
Re: Review Request 66044: Refactored resources chopping logic in allocator. |
Mon, 19 Mar, 23:48 |
| Meng Zhu |
Re: Review Request 66044: Refactored resources chopping logic in allocator. |
Mon, 19 Mar, 23:48 |
| Chun-Hung Hsiao |
Review Request 66162: Changed names in tests related to `DiskProfileAdaptor` for consistency. |
Mon, 19 Mar, 23:49 |
| Chun-Hung Hsiao |
Re: Review Request 61096: Building gRPC with CMake. |
Mon, 19 Mar, 23:50 |
| Chun-Hung Hsiao |
Re: Review Request 61118: libprocess: Building gRPC support with CMake. |
Mon, 19 Mar, 23:53 |
| Chun-Hung Hsiao |
Review Request 66163: Built storage local resource provider with CMake. |
Mon, 19 Mar, 23:59 |
| Gaston Kleiman |
Re: Review Request 66140: Fixed bug in `Framework::removeOperation()`. |
Tue, 20 Mar, 00:01 |
| Zhitao Li |
Re: Review Request 53267: Added log and counter for tracking subscribers. |
Tue, 20 Mar, 00:06 |
| Till Toenshoff |
Re: Review Request 65581: Made all allocator tests allow for slave backoff. |
Tue, 20 Mar, 00:16 |
| Mesos Reviewbot Windows |
Re: Review Request 66142: Added blank lines after multi-line logging statements in `master.cpp`. |
Tue, 20 Mar, 00:17 |
| Mesos Reviewbot Windows |
Re: Review Request 66141: Fixed whitespace in SLRP tests. |
Tue, 20 Mar, 00:54 |
| Mesos Reviewbot Windows |
Re: Review Request 53267: Added log and counter for tracking subscribers. |
Tue, 20 Mar, 01:02 |
| Mesos Reviewbot Windows |
Re: Review Request 66163: Built storage local resource provider with CMake. |
Tue, 20 Mar, 01:03 |
| Gaston Kleiman |
Re: Review Request 66058: Added v1 versions of some test helpers/matchers. |
Tue, 20 Mar, 01:54 |
| Chun-Hung Hsiao |
Re: Review Request 65974: Added comments and made some renaming in SLRP. |
Tue, 20 Mar, 02:05 |
| Mesos Reviewbot |
Re: Review Request 66141: Fixed whitespace in SLRP tests. |
Tue, 20 Mar, 02:24 |
| Andrew Schwartzmeyer |
Re: Review Request 66002: Fixed the HTTP API path variables on Windows. |
Tue, 20 Mar, 03:05 |
| Chun-Hung Hsiao |
Re: Review Request 65594: Checkpointed profiles in storage local resource provider. |
Tue, 20 Mar, 03:13 |
| Chun-Hung Hsiao |
Re: Review Request 65976: Allowed profiles to be missing from `DiskProfileAdaptor`. |
Tue, 20 Mar, 03:21 |
| Chun-Hung Hsiao |
Re: Review Request 65640: Fixed leaks and a race condition in `UriDiskProfileAdaptorTests`. |
Tue, 20 Mar, 03:23 |
| Chun-Hung Hsiao |
Re: Review Request 65666: Added a unit test for SLRP operation state metrics. |
Tue, 20 Mar, 03:27 |
| Chun-Hung Hsiao |
Re: Review Request 65875: Improved logging for offers and inverse offers. |
Tue, 20 Mar, 03:27 |
| Mesos Reviewbot Windows |
Re: Review Request 65875: Improved logging for offers and inverse offers. |
Tue, 20 Mar, 03:32 |
| Mesos Reviewbot |
Re: Review Request 66140: Fixed bug in `Framework::removeOperation()`. |
Tue, 20 Mar, 05:08 |
| Mesos Reviewbot |
Re: Review Request 66163: Built storage local resource provider with CMake. |
Tue, 20 Mar, 09:04 |
| Mesos Reviewbot |
Re: Review Request 65875: Improved logging for offers and inverse offers. |
Tue, 20 Mar, 09:53 |
| Alexander Rukletsov |
Re: Review Request 65694: Made the default executor's handling of kill escalations more robust. |
Tue, 20 Mar, 12:27 |
| Alexander Rukletsov |
Re: Review Request 65695: Made the default executor allow schedulers to retry task kills. |
Tue, 20 Mar, 12:27 |
| Alexander Rukletsov |
Re: Review Request 65695: Made the default executor allow schedulers to retry task kills. |
Tue, 20 Mar, 12:53 |
| Alexander Rukletsov |
Re: Review Request 65962: Avoided copying `Owned` pointers in the default executor. |
Tue, 20 Mar, 13:05 |
| Harold Dost |
Review Request 66173: Add test for new `disk/xfs` kill functionality. |
Tue, 20 Mar, 14:34 |
| Harold Dost |
Re: Review Request 66001: MESOS-6575: Add soft limit and kill to disk/xfs. |
Tue, 20 Mar, 14:35 |
| Benjamin Bannier |
Re: Review Request 66157: Fixed header inclusions for `csi/spec.hpp`. |
Tue, 20 Mar, 15:03 |
| Benjamin Bannier |
Re: Review Request 66161: Renamed the internal namespace `profile` to `storage`. |
Tue, 20 Mar, 15:04 |
| Benjamin Bannier |
Re: Review Request 66162: Changed names in tests related to `DiskProfileAdaptor` for consistency. |
Tue, 20 Mar, 15:04 |
| Benjamin Bannier |
Re: Review Request 66094: Bumped bundled gRPC to 1.10.0. |
Tue, 20 Mar, 15:05 |
| Benjamin Bannier |
Re: Review Request 66095: Fixed gRPC compilation in standalone libprocess build. |
Tue, 20 Mar, 15:05 |
| Benjamin Bannier |
Re: Review Request 66096: Adapted the new `grpcpp` C++ headers for gRPC v1.10 in libprocess. |
Tue, 20 Mar, 15:09 |
| Benjamin Bannier |
Re: Review Request 66097: Adapted the new `grpcpp` C++ headers for gRPC v1.10 in Mesos. |
Tue, 20 Mar, 15:09 |
| Mesos Reviewbot Windows |
Re: Review Request 66173: Add test for new `disk/xfs` kill functionality. |
Tue, 20 Mar, 15:39 |
| Benjamin Bannier |
Re: Review Request 66156: Compiled `csi.proto` when gRPC is disabled. |
Tue, 20 Mar, 15:55 |
| Benjamin Bannier |
Re: Review Request 66158: libprocess: Made tests `GRPCClientTest.*` cross-platform. |
Tue, 20 Mar, 15:59 |
| Benjamin Bannier |
Re: Review Request 66159: Made tests `CSIClientTest.*` cross-platform. |
Tue, 20 Mar, 16:00 |
| James Peach |
Review Request 66175: Added isolator checks for namespaces support. |
Tue, 20 Mar, 16:51 |
| Mesos Reviewbot Windows |
Re: Review Request 66175: Added isolator checks for namespaces support. |
Tue, 20 Mar, 18:02 |
| Meng Zhu |
Re: Review Request 66145: Added a test to verify that task launch order is enforced. |
Tue, 20 Mar, 18:35 |
| Andrei Budnik |
Review Request 66177: Fixed flakiness in ROOT_DOCKER_SlaveRecoveryTaskContainer test. |
Tue, 20 Mar, 18:35 |