| Mesos Reviewbot Windows |
Re: Review Request 66104: Fixed potential memory leak in the `volume/sandbox_path` isolator. |
Thu, 15 Mar, 23:40 |
| Jason Lai |
Re: Review Request 66034: Remount several proc filesystem entries as read-only. |
Thu, 15 Mar, 23:40 |
| Greg Mann |
Re: Review Request 63992: Handled incorrect offer operation IDs in master's ACCEPT handler. |
Fri, 16 Mar, 00:01 |
| Greg Mann |
Re: Review Request 63992: Handled incorrect offer operation IDs in master's ACCEPT handler. |
Fri, 16 Mar, 00:02 |
| Greg Mann |
Re: Review Request 63994: Added a new test for validation of offer operation IDs. |
Fri, 16 Mar, 00:06 |
| Mesos Reviewbot |
Re: Review Request 65571: Handle 'None' passed from the MasterDetector in 'Master::detect()'. |
Fri, 16 Mar, 00:09 |
| Gaston Kleiman |
Re: Review Request 63992: Handled incorrect offer operation IDs in master's ACCEPT handler. |
Fri, 16 Mar, 00:10 |
| Zhitao Li |
Re: Review Request 66104: Fixed potential memory leak in the `volume/sandbox_path` isolator. |
Fri, 16 Mar, 00:19 |
| Gaston Kleiman |
Re: Review Request 63994: Added a new test for validation of offer operation IDs. |
Fri, 16 Mar, 00:23 |
| Greg Mann |
Re: Review Request 63991: Added helpers to create and forward offer operation updates. |
Fri, 16 Mar, 00:59 |
| Greg Mann |
Re: Review Request 63992: Handled incorrect offer operation IDs in master's ACCEPT handler. |
Fri, 16 Mar, 01:54 |
| Greg Mann |
Re: Review Request 63994: Added a new test for validation of offer operation IDs. |
Fri, 16 Mar, 01:55 |
| Greg Mann |
Re: Review Request 63994: Added a new test for validation of offer operation IDs. |
Fri, 16 Mar, 01:55 |
| Mesos Reviewbot |
Re: Review Request 66104: Fixed potential memory leak in the `volume/sandbox_path` isolator. |
Fri, 16 Mar, 03:49 |
| Harold Dost |
Re: Review Request 66001: MESOS-6575: Add soft limit and kill to disk/xfs. |
Fri, 16 Mar, 10:43 |
| Michael Park |
Review Request 66115: Added `mesos-tidy.py`, a modified version of `run-clang-tidy.py`. |
Fri, 16 Mar, 10:57 |
| Michael Park |
Review Request 66114: Added supporting scripts for Mesos LLVM Tools. |
Fri, 16 Mar, 10:58 |
| Mesos Reviewbot Windows |
Re: Review Request 66001: MESOS-6575: Add soft limit and kill to disk/xfs. |
Fri, 16 Mar, 11:49 |
| Mesos Reviewbot |
Re: Review Request 66001: MESOS-6575: Add soft limit and kill to disk/xfs. |
Fri, 16 Mar, 12:39 |
| Mesos Reviewbot Windows |
Re: Review Request 66115: Added `mesos-tidy.py`, a modified version of `run-clang-tidy.py`. |
Fri, 16 Mar, 12:48 |
| Zhitao Li |
Re: Review Request 66049: Added offer operation to grow and shrink persistent volumes. |
Fri, 16 Mar, 15:57 |
| Chun-Hung Hsiao |
Re: Review Request 66049: Added offer operation to grow and shrink persistent volumes. |
Fri, 16 Mar, 16:48 |
| Zhitao Li |
Re: Review Request 66049: Added offer operation to grow and shrink persistent volumes. |
Fri, 16 Mar, 17:54 |
| Zhitao Li |
Re: Review Request 66052: Added new operator API to grow and shrink persistent volume. |
Fri, 16 Mar, 17:54 |
| Meng Zhu |
Review Request 66118: Updated an agent test to use mock authorizer. |
Fri, 16 Mar, 18:17 |
| Meng Zhu |
Review Request 66119: Added a mock sandbox garbage collector. |
Fri, 16 Mar, 18:17 |
| Meng Zhu |
Review Request 66120: Updated an agent test to use mock garbage collector. |
Fri, 16 Mar, 18:17 |
| Jie Yu |
Re: Review Request 66104: Fixed potential memory leak in the `volume/sandbox_path` isolator. |
Fri, 16 Mar, 18:47 |
| Jie Yu |
Re: Review Request 66104: Fixed potential memory leak in the `volume/sandbox_path` isolator. |
Fri, 16 Mar, 18:48 |
| Meng Zhu |
Re: Review Request 65679: Removed direct unmock calls and added missing mock call expectations. |
Fri, 16 Mar, 19:07 |
| Meng Zhu |
Re: Review Request 65679: Removed direct unmock calls and added missing mock call expectations. |
Fri, 16 Mar, 19:07 |
| Mesos Reviewbot Windows |
Re: Review Request 66120: Updated an agent test to use mock garbage collector. |
Fri, 16 Mar, 19:21 |
| Gaston Kleiman |
Re: Review Request 65693: Made the default executor fail kills if the response isn't "200 OK". |
Fri, 16 Mar, 19:53 |
| Gaston Kleiman |
Re: Review Request 65694: Made the default executor's handling of kill escalations more robust. |
Fri, 16 Mar, 19:53 |
| Gaston Kleiman |
Re: Review Request 65695: Made the default executor allow schedulers to retry task kills. |
Fri, 16 Mar, 19:53 |
| Gaston Kleiman |
Re: Review Request 65962: Avoided copying `Owned` pointers in the default executor. |
Fri, 16 Mar, 19:54 |
| Gaston Kleiman |
Review Request 66123: Temporarily disabled some default executor tests. |
Fri, 16 Mar, 19:54 |
| Greg Mann |
Re: Review Request 65994: Made the master forward operation status updates to the schedulers. |
Fri, 16 Mar, 20:00 |
| Joseph Wu |
Re: Review Request 66007: CMake: Set C++11 as standard automatically. |
Fri, 16 Mar, 20:45 |
| Greg Mann |
Re: Review Request 65993: Added evolve functions for operation status updates. |
Fri, 16 Mar, 20:53 |
| Greg Mann |
Re: Review Request 66056: Updated `CREATE_VOLUME()` helper to allow specifying an operation ID. |
Fri, 16 Mar, 20:55 |
| Greg Mann |
Re: Review Request 66057: Added a `createCallAcknowledgeOperationStatus()` test helper. |
Fri, 16 Mar, 20:58 |
| Mesos Reviewbot Windows |
Re: Review Request 66123: Temporarily disabled some default executor tests. |
Fri, 16 Mar, 20:59 |
| Gaston Kleiman |
Re: Review Request 65994: Made the master forward operation status updates to the schedulers. |
Fri, 16 Mar, 21:07 |
| Joseph Wu |
Re: Review Request 66008: CMake: Enabled compiler warnings. |
Fri, 16 Mar, 21:18 |
| Andrew Schwartzmeyer |
Re: Review Request 66123: Temporarily disabled some default executor tests. |
Fri, 16 Mar, 21:39 |
| Chun-Hung Hsiao |
Re: Review Request 66076: Used raw string literal in protobuf tests to avoid escaping. |
Fri, 16 Mar, 21:40 |
| Joseph Wu |
Re: Review Request 66009: CMake: Added `-Wno-unused-local-typedefs` to Boost interface. |
Fri, 16 Mar, 21:48 |
| Mesos Reviewbot |
Re: Review Request 66115: Added `mesos-tidy.py`, a modified version of `run-clang-tidy.py`. |
Fri, 16 Mar, 21:48 |
| Jie Yu |
Re: Review Request 66049: Added offer operation to grow and shrink persistent volumes. |
Fri, 16 Mar, 22:00 |
| Joseph Wu |
Re: Review Request 66010: Windows: Switched to default CRT linkage. |
Fri, 16 Mar, 22:08 |
| Mesos Reviewbot Windows |
Re: Review Request 66123: Temporarily disabled some default executor tests. |
Fri, 16 Mar, 22:20 |
| Andrew Schwartzmeyer |
Re: Review Request 66010: Windows: Switched to default CRT linkage. |
Fri, 16 Mar, 22:32 |
| Jie Yu |
Re: Review Request 65811: Add `path::clean` to stout for normalizing path (for POSIX only now) |
Fri, 16 Mar, 23:16 |
| Jie Yu |
Re: Review Request 65811: Add `path::clean` to stout for normalizing path (for POSIX only now) |
Fri, 16 Mar, 23:17 |
| Jie Yu |
Re: Review Request 65811: Add `path::clean` to stout for normalizing path (for POSIX only now) |
Fri, 16 Mar, 23:19 |
| Jie Yu |
Re: Review Request 65812: Added an overloaded version of `os::realpath` to stout |
Fri, 16 Mar, 23:20 |
| Jie Yu |
Re: Review Request 66034: Remount several proc filesystem entries as read-only. |
Fri, 16 Mar, 23:41 |
| Jie Yu |
Re: Review Request 66104: Fixed potential memory leak in the `volume/sandbox_path` isolator. |
Fri, 16 Mar, 23:44 |
| Mesos Reviewbot |
Re: Review Request 66123: Temporarily disabled some default executor tests. |
Sat, 17 Mar, 00:42 |
| Mesos Reviewbot Windows |
Re: Review Request 66115: Added `mesos-tidy.py`, a modified version of `run-clang-tidy.py`. |
Sat, 17 Mar, 01:05 |
| Benjamin Mahler |
Re: Review Request 66044: Refactored resources chopping logic in allocator. |
Sat, 17 Mar, 02:26 |
| Mesos Reviewbot |
Re: Review Request 66115: Added `mesos-tidy.py`, a modified version of `run-clang-tidy.py`. |
Sat, 17 Mar, 03:47 |
| Meng Zhu |
Re: Review Request 66004: Updated task reconciliation path to avoid copying in v1. |
Sun, 18 Mar, 18:08 |
| Meng Zhu |
Re: Review Request 65334: Added quota limit to the master API protos. |
Sun, 18 Mar, 18:27 |
| Meng Zhu |
Re: Review Request 65851: Disallow limit in /quota requests and SET_QUOTA calls. |
Sun, 18 Mar, 18:31 |
| Meng Zhu |
Re: Review Request 65782: Implemented master::Call validation for UPDATE_QUOTA. |
Sun, 18 Mar, 18:47 |
| Meng Zhu |
Re: Review Request 65783: Added a test for validation of UPDATE_QUOTA master::Call. |
Sun, 18 Mar, 18:59 |
| Meng Zhu |
Re: Review Request 65782: Implemented master::Call validation for UPDATE_QUOTA. |
Sun, 18 Mar, 19:43 |
| Meng Zhu |
Re: Review Request 65334: Added quota limit to the master API protos. |
Sun, 18 Mar, 20:27 |
| Meng Zhu |
Re: Review Request 65784: Added validation of QuotaRequest. |
Sun, 18 Mar, 20:28 |
| Meng Zhu |
Re: Review Request 65853: Updated createQuotaInfo helper to handle quota limit. |
Sun, 18 Mar, 21:07 |
| Jason Lai |
Re: Review Request 65812: Added an overloaded version of `os::realpath` to stout |
Mon, 19 Mar, 00:10 |
| Benjamin Bannier |
Re: Review Request 66114: Added supporting scripts for Mesos LLVM Tools. |
Mon, 19 Mar, 12:25 |
| Benjamin Bannier |
Re: Review Request 66115: Added `mesos-tidy.py`, a modified version of `run-clang-tidy.py`. |
Mon, 19 Mar, 12:35 |
| Benjamin Bannier |
Re: Review Request 66008: CMake: Enabled compiler warnings. |
Mon, 19 Mar, 13:35 |
| Alexander Rukletsov |
Re: Review Request 65581: Made all allocator tests allow for slave backoff. |
Mon, 19 Mar, 14:14 |
| Benjamin Bannier |
Review Request 66137: Removed some redundant `get` calls. |
Mon, 19 Mar, 15:16 |
| Benno Evers |
Re: Review Request 66137: Removed some redundant `get` calls. |
Mon, 19 Mar, 15:17 |
| Tomasz Janiszewski |
Review Request 66138: Add dockerfile for ARM. |
Mon, 19 Mar, 15:23 |
| James Peach |
Re: Review Request 66138: Add dockerfile for ARM. |
Mon, 19 Mar, 16:18 |
| Mesos Reviewbot Windows |
Re: Review Request 66137: Removed some redundant `get` calls. |
Mon, 19 Mar, 16:21 |
| Zhitao Li |
Re: Review Request 63992: Handled incorrect offer operation IDs in master's ACCEPT handler. |
Mon, 19 Mar, 16:31 |
| Zhitao Li |
Re: Review Request 63994: Added a new test for validation of offer operation IDs. |
Mon, 19 Mar, 16:35 |
| Zhitao Li |
Re: Review Request 65300: Added master metrics for operation status acknowledgments handling. |
Mon, 19 Mar, 16:41 |
| Gaston Kleiman |
Re: Review Request 65300: Added master metrics for operation status acknowledgments handling. |
Mon, 19 Mar, 16:44 |
| Zhitao Li |
Re: Review Request 64618: Implemented the master's `ACKNOWLEDGE_OPERATION_STATUS` handler. |
Mon, 19 Mar, 16:50 |
| Zhitao Li |
Re: Review Request 65994: Made the master forward operation status updates to the schedulers. |
Mon, 19 Mar, 16:54 |
| Zhitao Li |
Re: Review Request 66056: Updated `CREATE_VOLUME()` helper to allow specifying an operation ID. |
Mon, 19 Mar, 16:56 |
| Zhitao Li |
Re: Review Request 66057: Added a `createCallAcknowledgeOperationStatus()` test helper. |
Mon, 19 Mar, 16:56 |
| Zhitao Li |
Re: Review Request 66059: Added a `SendAcknowledgeOperationStatus` test action. |
Mon, 19 Mar, 17:03 |
| Andrew Schwartzmeyer |
Re: Review Request 66008: CMake: Enabled compiler warnings. |
Mon, 19 Mar, 17:05 |
| Zhitao Li |
Re: Review Request 66060: Added end-to-end tests for operation feedback. |
Mon, 19 Mar, 17:12 |
| Gaston Kleiman |
Re: Review Request 64618: Implemented the master's `ACKNOWLEDGE_OPERATION_STATUS` handler. |
Mon, 19 Mar, 17:14 |
| Zhitao Li |
Re: Review Request 66058: Added v1 versions of some test helpers/matchers. |
Mon, 19 Mar, 17:14 |
| Gaston Kleiman |
Re: Review Request 66058: Added v1 versions of some test helpers/matchers. |
Mon, 19 Mar, 17:17 |
| Gaston Kleiman |
Re: Review Request 66060: Added end-to-end tests for operation feedback. |
Mon, 19 Mar, 17:20 |
| Zhitao Li |
Re: Review Request 64618: Implemented the master's `ACKNOWLEDGE_OPERATION_STATUS` handler. |
Mon, 19 Mar, 17:21 |
| Mesos Reviewbot Windows |
Re: Review Request 66138: Add dockerfile for ARM. |
Mon, 19 Mar, 17:22 |
| Gaston Kleiman |
Re: Review Request 64618: Implemented the master's `ACKNOWLEDGE_OPERATION_STATUS` handler. |
Mon, 19 Mar, 17:30 |