| Benjamin Bannier |
Re: Review Request 66012: CMake: Split `CMAKE_FORWARD_ARGS` into `C` and `CXX` versions. |
Wed, 14 Mar, 16:44 |
| Benjamin Bannier |
Re: Review Request 66046: CMake: Patched Boost to remove spurious warnings. |
Wed, 14 Mar, 16:47 |
| Greg Mann |
Re: Review Request 63992: Handled incorrect offer operation IDs in master's ACCEPT handler. |
Wed, 14 Mar, 16:58 |
| Mesos Reviewbot Windows |
Re: Review Request 66070: Document new `slave/recovery_time_secs` gauge. |
Wed, 14 Mar, 17:29 |
| Andrew Schwartzmeyer |
Re: Review Request 66007: CMake: Set C++11 as standard automatically. |
Wed, 14 Mar, 17:47 |
| Andrew Schwartzmeyer |
Re: Review Request 66008: CMake: Enabled compiler warnings. |
Wed, 14 Mar, 17:56 |
| Andrew Schwartzmeyer |
Re: Review Request 66008: CMake: Enabled compiler warnings. |
Wed, 14 Mar, 17:57 |
| Andrew Schwartzmeyer |
Re: Review Request 66009: CMake: Added `-Wno-unused-local-typedefs` to Boost interface. |
Wed, 14 Mar, 17:58 |
| Andrew Schwartzmeyer |
Re: Review Request 66012: CMake: Split `CMAKE_FORWARD_ARGS` into `C` and `CXX` versions. |
Wed, 14 Mar, 18:01 |
| Zhitao Li |
Re: Review Request 65959: Added a test to make sure `slave/recovery_time_secs` is reported. |
Wed, 14 Mar, 18:03 |
| Andrew Schwartzmeyer |
Re: Review Request 66046: CMake: Patched Boost to remove spurious warnings. |
Wed, 14 Mar, 18:07 |
| Andrew Schwartzmeyer |
Re: Review Request 66046: CMake: Patched Boost to remove spurious warnings. |
Wed, 14 Mar, 18:07 |
| James Peach |
Re: Review Request 65954: Add a gauge for how long agent recovery takes. |
Wed, 14 Mar, 18:16 |
| Andrew Schwartzmeyer |
Re: Review Request 66046: CMake: Patched Boost to remove spurious warnings. |
Wed, 14 Mar, 18:44 |
| James Peach |
Re: Review Request 65959: Added a test to make sure `slave/recovery_time_secs` is reported. |
Wed, 14 Mar, 19:04 |
| James Peach |
Re: Review Request 66070: Document new `slave/recovery_time_secs` gauge. |
Wed, 14 Mar, 19:13 |
| Andrew Schwartzmeyer |
Re: Review Request 65997: Made `PROTOC_GENERATE` compile proto files from 3rd-party libraries. |
Wed, 14 Mar, 19:50 |
| Andrew Schwartzmeyer |
Re: Review Request 66002: Fixed the HTTP API path variables on Windows. |
Wed, 14 Mar, 20:04 |
| Andrew Schwartzmeyer |
Re: Review Request 66002: Fixed the HTTP API path variables on Windows. |
Wed, 14 Mar, 20:06 |
| Andrew Schwartzmeyer |
Re: Review Request 66015: Built CSI spec proto files with cmake. |
Wed, 14 Mar, 20:07 |
| Chun-Hung Hsiao |
Re: Review Request 65997: Made `PROTOC_GENERATE` compile proto files from 3rd-party libraries. |
Wed, 14 Mar, 20:25 |
| Benjamin Mahler |
Re: Review Request 66043: Renamed a variable in allocator to be consistent with others. |
Wed, 14 Mar, 20:47 |
| Benjamin Mahler |
Re: Review Request 66045: Renamed `resources` in allocator to `toAllocate`. |
Wed, 14 Mar, 20:49 |
| Jason Lai |
Re: Review Request 65811: Add `path::clean` to stout for normalizing path (for POSIX only now) |
Wed, 14 Mar, 21:15 |
| Jeff Coffler |
Re: Review Request 66002: Fixed the HTTP API path variables on Windows. |
Wed, 14 Mar, 21:22 |
| Jeff Coffler |
Re: Review Request 66046: CMake: Patched Boost to remove spurious warnings. |
Wed, 14 Mar, 21:27 |
| Jeff Coffler |
Re: Review Request 66046: CMake: Patched Boost to remove spurious warnings. |
Wed, 14 Mar, 21:27 |
| Jason Lai |
Re: Review Request 65899: Use launch actions in `MesosContainerizerLaunchHelper` instead. |
Wed, 14 Mar, 21:42 |
| Chun-Hung Hsiao |
Re: Review Request 65997: Made `PROTOC_GENERATE` compile proto files from 3rd-party libraries. |
Wed, 14 Mar, 22:00 |
| Chun-Hung Hsiao |
Re: Review Request 65997: Made `PROTOC_GENERATE` compile proto files from 3rd-party libraries. |
Wed, 14 Mar, 23:05 |
| Andrew Schwartzmeyer |
Re: Review Request 66008: CMake: Enabled compiler warnings. |
Wed, 14 Mar, 23:10 |
| Andrew Schwartzmeyer |
Re: Review Request 66009: CMake: Added `-Wno-unused-local-typedefs` to Boost interface. |
Wed, 14 Mar, 23:11 |
| Andrew Schwartzmeyer |
Re: Review Request 66012: CMake: Split `CMAKE_FORWARD_ARGS` into `C` and `CXX` versions. |
Wed, 14 Mar, 23:15 |
| Andrew Schwartzmeyer |
Re: Review Request 66013: Windows: Made ZooKeeper use default CRT linking. |
Wed, 14 Mar, 23:16 |
| Andrew Schwartzmeyer |
Re: Review Request 66046: CMake: Patched Boost to remove spurious warnings. |
Wed, 14 Mar, 23:18 |
| Mesos Reviewbot |
Re: Review Request 66060: Added end-to-end tests for operation feedback. |
Wed, 14 Mar, 23:32 |
| Andrew Schwartzmeyer |
Re: Review Request 66015: Built CSI spec proto files with cmake. |
Wed, 14 Mar, 23:44 |
| Andrew Schwartzmeyer |
Re: Review Request 65997: Made `PROTOC_GENERATE` compile proto files from 3rd-party libraries. |
Wed, 14 Mar, 23:45 |
| Gaston Kleiman |
Re: Review Request 64618: Implemented the master's `ACKNOWLEDGE_OPERATION_STATUS` handler. |
Wed, 14 Mar, 23:50 |
| Gaston Kleiman |
Re: Review Request 64618: Implemented the master's `ACKNOWLEDGE_OPERATION_STATUS` handler. |
Wed, 14 Mar, 23:50 |
| Andrew Schwartzmeyer |
Re: Review Request 65997: Made `PROTOC_GENERATE` compile proto files from 3rd-party libraries. |
Wed, 14 Mar, 23:51 |
| Chun-Hung Hsiao |
Re: Review Request 65679: Removed direct unmock calls and added missing mock call expectations. |
Thu, 15 Mar, 00:08 |
| Mesos Reviewbot Windows |
Re: Review Request 66046: CMake: Patched Boost to remove spurious warnings. |
Thu, 15 Mar, 00:15 |
| Chun-Hung Hsiao |
Re: Review Request 66015: Built CSI spec proto files with CMake. |
Thu, 15 Mar, 00:30 |
| Chun-Hung Hsiao |
Re: Review Request 65997: Made `PROTOC_GENERATE` compile proto files from 3rd-party libraries. |
Thu, 15 Mar, 00:30 |
| Andrew Schwartzmeyer |
Re: Review Request 66015: Built CSI spec proto files with CMake. |
Thu, 15 Mar, 01:45 |
| Andrew Schwartzmeyer |
Re: Review Request 65997: Made `PROTOC_GENERATE` compile proto files from 3rd-party libraries. |
Thu, 15 Mar, 01:45 |
| Andrew Schwartzmeyer |
Re: Review Request 65997: Made `PROTOC_GENERATE` compile proto files from 3rd-party libraries. |
Thu, 15 Mar, 01:46 |
| Mesos Reviewbot |
Re: Review Request 65833: Displayed resource provider resources in GET_AGENTS response. |
Thu, 15 Mar, 02:23 |
| Qian Zhang |
Review Request 66076: Used raw string literal in protobuf tests to avoid escaping. |
Thu, 15 Mar, 02:38 |
| Qian Zhang |
Re: Review Request 59989: Added a test `ProtobufTest.JsonifyMap`. |
Thu, 15 Mar, 02:39 |
| Mesos Reviewbot Windows |
Re: Review Request 66076: Used raw string literal in protobuf tests to avoid escaping. |
Thu, 15 Mar, 03:36 |
| Sagar Patwardhan |
Re: Review Request 65987: Allow nested containers in pods to have separate namespaces(Ref: MESOS-8534). |
Thu, 15 Mar, 04:30 |
| Mesos Reviewbot Windows |
Re: Review Request 65987: Allow nested containers in pods to have separate namespaces(Ref: MESOS-8534). |
Thu, 15 Mar, 05:01 |
| Mesos Reviewbot |
Re: Review Request 66037: Enabled agent resource provider capability by default. |
Thu, 15 Mar, 08:12 |
| Jason Lai |
Re: Review Request 65898: Add `MesosContainerizerLaunchHelper` and subclasses for different OSes. |
Thu, 15 Mar, 08:17 |
| Jason Lai |
Re: Review Request 65899: Use launch actions in `MesosContainerizerLaunchHelper` instead. |
Thu, 15 Mar, 08:18 |
| Qian Zhang |
Re: Review Request 66076: Used raw string literal in protobuf tests to avoid escaping. |
Thu, 15 Mar, 09:29 |
| Mesos Reviewbot Windows |
Re: Review Request 66076: Used raw string literal in protobuf tests to avoid escaping. |
Thu, 15 Mar, 10:27 |
| Mesos Reviewbot |
Re: Review Request 64970: Use tox for linting and testing code living uder src/python. |
Thu, 15 Mar, 13:21 |
| Harold Dost |
Re: Review Request 66001: MESOS-6575: Add soft limit and kill to disk/xfs. |
Thu, 15 Mar, 13:27 |
| Mesos Reviewbot Windows |
Re: Review Request 66001: MESOS-6575: Add soft limit and kill to disk/xfs. |
Thu, 15 Mar, 13:31 |
| Harold Dost |
Re: Review Request 66001: MESOS-6575: Add soft limit and kill to disk/xfs. |
Thu, 15 Mar, 13:33 |
| Mesos Reviewbot Windows |
Re: Review Request 66001: MESOS-6575: Add soft limit and kill to disk/xfs. |
Thu, 15 Mar, 13:41 |
| Harold Dost |
Re: Review Request 66001: MESOS-6575: Add soft limit and kill to disk/xfs. |
Thu, 15 Mar, 13:48 |
| Alexander Rojas |
Review Request 66088: Fixed crash on macOS during certain authorization calls. |
Thu, 15 Mar, 13:59 |
| Benno Evers |
Re: Review Request 65571: Handle 'None' passed from the MasterDetector in 'Master::detect()'. |
Thu, 15 Mar, 14:19 |
| Benno Evers |
Re: Review Request 66088: Fixed crash on macOS during certain authorization calls. |
Thu, 15 Mar, 14:21 |
| Alexander Rojas |
Re: Review Request 66088: Fixed crash on macOS during certain authorization calls. |
Thu, 15 Mar, 14:27 |
| Mesos Reviewbot Windows |
Re: Review Request 66001: MESOS-6575: Add soft limit and kill to disk/xfs. |
Thu, 15 Mar, 14:36 |
| Jan Schlicht |
Re: Review Request 66088: Fixed crash on macOS during certain authorization calls. |
Thu, 15 Mar, 14:36 |
| Alexander Rojas |
Re: Review Request 66088: Fixed crash on macOS during certain authorization calls. |
Thu, 15 Mar, 14:39 |
| Mesos Reviewbot Windows |
Re: Review Request 65571: Handle 'None' passed from the MasterDetector in 'Master::detect()'. |
Thu, 15 Mar, 15:21 |
| Chun-Hung Hsiao |
Re: Review Request 65679: Removed direct unmock calls and added missing mock call expectations. |
Thu, 15 Mar, 16:01 |
| Harold Dost |
Re: Review Request 66001: MESOS-6575: Add soft limit and kill to disk/xfs. |
Thu, 15 Mar, 16:14 |
| Mesos Reviewbot Windows |
Re: Review Request 66001: MESOS-6575: Add soft limit and kill to disk/xfs. |
Thu, 15 Mar, 17:18 |
| Eric Chung |
Re: Review Request 65899: Use launch actions in `MesosContainerizerLaunchHelper` instead. |
Thu, 15 Mar, 18:10 |
| Jason Lai |
Re: Review Request 66034: Remount several proc filesystem entries as read-only. |
Thu, 15 Mar, 18:24 |
| Zhitao Li |
Re: Review Request 66034: Remount several proc filesystem entries as read-only. |
Thu, 15 Mar, 18:30 |
| Alexander Rukletsov |
Re: Review Request 65571: Handle 'None' passed from the MasterDetector in 'Master::detect()'. |
Thu, 15 Mar, 18:41 |
| Mesos Reviewbot |
Re: Review Request 66076: Used raw string literal in protobuf tests to avoid escaping. |
Thu, 15 Mar, 19:10 |
| Chun-Hung Hsiao |
Re: Review Request 66049: Added offer operation to grow and shrink persistent volumes. |
Thu, 15 Mar, 19:10 |
| Chun-Hung Hsiao |
Review Request 66094: Bumped bundled gRPC to 1.10.0. |
Thu, 15 Mar, 19:18 |
| Chun-Hung Hsiao |
Review Request 66095: Fixed gRPC compilation in standalone libprocess build. |
Thu, 15 Mar, 19:19 |
| Chun-Hung Hsiao |
Review Request 66096: Adapted the new `grpcpp` C++ headers for gRPC v1.10 in libprocess. |
Thu, 15 Mar, 19:20 |
| Chun-Hung Hsiao |
Review Request 66097: Adapted the new `grpcpp` C++ headers for gRPC v1.10 in Mesos. |
Thu, 15 Mar, 19:21 |
| Mesos Reviewbot Windows |
Re: Review Request 66096: Adapted the new `grpcpp` C++ headers for gRPC v1.10 in libprocess. |
Thu, 15 Mar, 19:21 |
| Mesos Reviewbot Windows |
Re: Review Request 66097: Adapted the new `grpcpp` C++ headers for gRPC v1.10 in Mesos. |
Thu, 15 Mar, 19:31 |
| Jie Yu |
Re: Review Request 65987: Allow nested containers in pods to have separate namespaces(Ref: MESOS-8534). |
Thu, 15 Mar, 21:08 |
| Jie Yu |
Review Request 66101: Added a helper to parse ContainerID. |
Thu, 15 Mar, 21:11 |
| Sagar Patwardhan |
Re: Review Request 65987: Allow nested containers in pods to have separate namespaces(Ref: MESOS-8534). |
Thu, 15 Mar, 21:17 |
| Mesos Reviewbot |
Re: Review Request 66001: MESOS-6575: Add soft limit and kill to disk/xfs. |
Thu, 15 Mar, 21:19 |
| Jie Yu |
Re: Review Request 65987: Allow nested containers in pods to have separate namespaces(Ref: MESOS-8534). |
Thu, 15 Mar, 21:41 |
| Mesos Reviewbot Windows |
Re: Review Request 65571: Handle 'None' passed from the MasterDetector in 'Master::detect()'. |
Thu, 15 Mar, 21:56 |
| Mesos Reviewbot Windows |
Re: Review Request 66001: MESOS-6575: Add soft limit and kill to disk/xfs. |
Thu, 15 Mar, 22:09 |
| Mesos Reviewbot |
Re: Review Request 66097: Adapted the new `grpcpp` C++ headers for gRPC v1.10 in Mesos. |
Thu, 15 Mar, 22:09 |
| Mesos Reviewbot Windows |
Re: Review Request 66101: Added a helper to parse ContainerID. |
Thu, 15 Mar, 22:23 |
| Jason Lai |
Review Request 66104: Fixed potential memory leak in the `volume/sandbox_path` isolator. |
Thu, 15 Mar, 22:31 |
| Gilbert Song |
Re: Review Request 66104: Fixed potential memory leak in the `volume/sandbox_path` isolator. |
Thu, 15 Mar, 22:33 |
| Gilbert Song |
Re: Review Request 66104: Fixed potential memory leak in the `volume/sandbox_path` isolator. |
Thu, 15 Mar, 23:33 |